Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

board: port to iotlab M3 of A8 #5167

Merged
merged 1 commit into from
Jun 6, 2016
Merged

Conversation

aabadie
Copy link
Contributor

@aabadie aabadie commented Mar 24, 2016

Here is a port to the iotlab-a8-m3. I tried to factorize the code with iotlab-m3 as the only changes are:

  • some sensor to remove (isl29020 and lps331ap)
  • use a different SPI interface (2 instead of 1) and some GPIO changed

I put all the common code in a boards/iotlab-common directory and the specific code in boards/iotlab-m3 and boards/iotlab-a8-m3.

@OlegHahm OlegHahm added Platform: ARM Platform: This PR/issue effects ARM-based platforms Type: new feature The issue requests / The PR implemements a new feature for RIOT labels Mar 24, 2016
@cgundogan cgundogan added Type: new feature The issue requests / The PR implemements a new feature for RIOT and removed Type: new feature The issue requests / The PR implemements a new feature for RIOT labels Mar 24, 2016
@aabadie aabadie force-pushed the iotlab-a8-m3 branch 3 times, most recently from 95b0ad1 to d29621f Compare March 24, 2016 21:43
@aabadie aabadie changed the title BOARD Port to Iotlab a8 m3 board: port to iotlab M3 of A8 Mar 24, 2016
@OlegHahm OlegHahm assigned cgundogan and unassigned OlegHahm Mar 28, 2016
@miri64 miri64 modified the milestone: Release 2016.07 Mar 29, 2016
@emmanuelsearch
Copy link
Member

@kYc0o can you review and test this on the hardware?
Would be great to have support for this in the release.

@kYc0o
Copy link
Contributor

kYc0o commented Mar 30, 2016

Yes sure! I'll review it asap.

@aabadie
Copy link
Contributor Author

aabadie commented Apr 5, 2016

branch rebased and conflicts fixed.

@aabadie
Copy link
Contributor Author

aabadie commented Apr 29, 2016

Any comment on this one ?

@kYc0o
Copy link
Contributor

kYc0o commented Apr 29, 2016

Sorry for the delay, I'll look into this ASAP.

@aabadie
Copy link
Contributor Author

aabadie commented May 20, 2016

Rebased and fixed conflicts with master.

@aabadie aabadie force-pushed the iotlab-a8-m3 branch 3 times, most recently from 0a89ba5 to 04b351e Compare May 31, 2016 12:43
@aabadie
Copy link
Contributor Author

aabadie commented May 31, 2016

For the record, I updated the initial branch:

  • openocd config files were not found by the flash target : the dist directory is duplicated in both directories
  • my previous rebase broke the iotlab-m3 code. It should be fixed now.

@kYc0o
Copy link
Contributor

kYc0o commented Jun 6, 2016

Tested in the new IoT-Lab Saclay site, working like a charm. Thanks @aabadie ! Can you add a small wiki and reference the tutorial to test this new functionality?

I tested this PR with the upstream master with this PR merged, so if you want you can reference the upstream repo when merged.

ACK and let's Murdock have a last word!

@kYc0o kYc0o added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Jun 6, 2016
@kYc0o
Copy link
Contributor

kYc0o commented Jun 6, 2016

and go!

@kYc0o kYc0o merged commit 69b1ef3 into RIOT-OS:master Jun 6, 2016
@kYc0o
Copy link
Contributor

kYc0o commented Jun 6, 2016

Ah! I just forgot a small (but important) thing... can you add your name to the sources you've modified? @OlegHahm what's the procedure on this case? Should he add it on a new PR?

@OlegHahm
Copy link
Member

OlegHahm commented Jun 9, 2016

Would be probably the best, yes.

@aabadie aabadie deleted the iotlab-a8-m3 branch October 3, 2016 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: ARM Platform: This PR/issue effects ARM-based platforms Type: new feature The issue requests / The PR implemements a new feature for RIOT
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants