Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make: buildtest: pass GIT_CACHE_DIR to buildtest targets #5152

Merged
merged 1 commit into from
Mar 23, 2016
Merged

make: buildtest: pass GIT_CACHE_DIR to buildtest targets #5152

merged 1 commit into from
Mar 23, 2016

Conversation

kaspar030
Copy link
Contributor

Currently, make buildtest and thus the CI cannot use the cache as the directory is not passed on to the env caged "buildtest" target.

@kaspar030 kaspar030 added Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation Area: build system Area: Build system Area: CI Area: Continuous Integration of RIOT components labels Mar 23, 2016
@miri64
Copy link
Member

miri64 commented Mar 23, 2016

I don't understand this syntax... can you explain?

@cgundogan
Copy link
Member

sets GIT_CACHE_DIR only if it is in the current environment, otherwise it does not add GIT_CACHE_DIR to the new environment.

@kaspar030
Copy link
Contributor Author

${VAR:+<text> outputs is VAR is non-empty. We use that to add "GIT_CACHE_DIR=${GIT_CACHE_DIR}" as parameter to env, but only if the variable is set. Add some double "$$" for make. Rinse. Repeat.

@kaspar030 kaspar030 added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Mar 23, 2016
@cgundogan
Copy link
Member

ACK

@kaspar030
Copy link
Contributor Author

Murdock happy -> go.

@kaspar030 kaspar030 merged commit 3d9f66e into RIOT-OS:master Mar 23, 2016
@kaspar030 kaspar030 deleted the pass_git_cache_dir_to_buildtest branch March 23, 2016 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@miri64 miri64

Labels
Area: build system Area: Build system Area: CI Area: Continuous Integration of RIOT components CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kaspar030 @miri64 @cgundogan