gnrc_rpl: new default route when old one was deleted #5141
Conversation
cgundogan
added
Type: bug
cgundogan
added
the
State: waiting for other PR
cgundogan
force-pushed
the
pr/gnrc_rpl/remove_parent_create_new_fib_entry
branch
from
19fb23b to
eae0e4c
Compare
|
rebased to current master and changed the approach of updating the fib |
cgundogan
removed
the
State: waiting for other PR
|
how to test? |
| sizeof(ipv6_addr_t), | ||
| FIB_FLAG_RPL_ROUTE, | ||
| (parent->next->lifetime - now) * SEC_IN_MS); | ||
| } |
There was a problem hiding this comment.
yes, for the case that this parent (to delete) is not the preferred parent, the fib default entry is not removed and should still point to the preferred parent
There was a problem hiding this comment.
oops, looked at the wrong if:
if there is no parent->next then we basically have no parents left, so we cannot add a new fib entry
There was a problem hiding this comment.
but we could remove the removed parent from the FIB
There was a problem hiding this comment.
That's done in line 200 if I understand you correctly
|
Taking the next parent from the parent set seems a correct approach to me, and the RFC6550 doesn't give a detailed procedure which parent should be chosen [1]. |
BytesGalore
added
the
CI: ready for build
|
Murdock is happy - GO |
Currently, when a node has two parents and the preferred parent times out, the fib entry is not updated accordingly to point to the new preferred parent until a DIO is received.
This PR adds the new default route pointing to the next preferred parent as soon as the former one gets deleted.
Depends on #5135