msp430 spi speed fix + USIC/USCI cleanup #5127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ups :-) Looks good, untested ACK |
haukepetersen
added
Type: bug
|
👍 ACK |
| if (br < 2) { | ||
| br = 2; | ||
| } | ||
|
|
There was a problem hiding this comment.
cpu/msp430fxyz/periph/spi.c:92: trailing whitespace.
+
cpu/msp430fxyz/periph/spi.c:161: trailing whitespace.
+ if (br < 2) {
cpu/msp430fxyz/periph/spi.c:164: trailing whitespace.
+
cpu/msp430fxyz/periph/spi.c:92: trailing whitespace.
+
cpu/msp430fxyz/periph/spi.c:161: trailing whitespace.
+ if (br < 2) {
cpu/msp430fxyz/periph/spi.c:164: trailing whitespace.
+
ERROR: This change introduces new whitespace errors
malosek
force-pushed
the
msp430_spi_speed_fix
branch
from
4d62495 to
d8b45b0
Compare
Signed-off-by: malo <malo@25cmsquare.io>
Signed-off-by: malo <malo@25cmsquare.io>
malosek
force-pushed
the
msp430_spi_speed_fix
branch
from
d8b45b0 to
f093d10
Compare
|
Should be better now, noticed even bad alignment of break statement. wbr |
|
CI is happy -> go. Thanks for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
minor issue with spi speed configuration + definitive solution for USIC/USCI confusion.
wbr
malo