Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sys/uart_stdio: Move macro definitions to header file, rename STDIO -> UART_STDIO_DEV #5023

Merged
merged 1 commit into from
Mar 11, 2016
Merged

sys/uart_stdio: Move macro definitions to header file, rename STDIO -> UART_STDIO_DEV #5023

merged 1 commit into from
Mar 11, 2016

Conversation

jnohlgard
Copy link
Member

This allows ethos to use STDIO as its default port when not specifying ETHOS_UART and ETHOS_BAUDRATE via CFLAGS or other headers

@jnohlgard jnohlgard added Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation Area: network Area: Networking Area: drivers Area: Device drivers labels Mar 9, 2016
@jnohlgard jnohlgard added this to the Release 2016.04 milestone Mar 9, 2016
@OlegHahm
Copy link
Member

OlegHahm commented Mar 9, 2016

Shouldn't these (now global) defines get a prefix, i.e. UART_ then?

@kaspar030
Copy link
Contributor

ACK. Sorry, overlooked @OlegHahm's comment.

@kaspar030 kaspar030 added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Mar 10, 2016
@kaspar030
Copy link
Contributor

Shouldn't these (now global) defines get a prefix, i.e. UART_ then?

Well, STDIO was defined in the periph_conf's of the boards, right? So they're as global as before?

@jnohlgard
Copy link
Member Author

board.h, but yes, it's already global, but it does make sense to rename it IMO. Is UART_STDIO_DEV and UART_STDIO_BAUDRATE fine as names?

@OlegHahm
Copy link
Member

Fine with me.

@jnohlgard jnohlgard force-pushed the pr/uart-stdio-defines branch from 9e06633 to baf3ff3 Compare March 11, 2016 10:05
@jnohlgard jnohlgard changed the title sys/uart_stdio: Move macro definitions to header file sys/uart_stdio: Move macro definitions to header file, rename STDIO -> UART_STDIO_DEV Mar 11, 2016
@jnohlgard jnohlgard force-pushed the pr/uart-stdio-defines branch 2 times, most recently from 71aa36e to 5244a92 Compare March 11, 2016 10:08
@jnohlgard
Copy link
Member Author

  • renamed STDIO -> UART_STDIO_DEV
  • renamed STDIO_BAUDRATE -> UART_STDIO_BAUDRATE
  • renamed STDIO_RX_BUFSIZE -> UART_STDIO_RX_BUFSIZE

@OlegHahm OlegHahm added the CI: needs squashing Commits in this PR need to be squashed; If set, CI systems will mark this PR as unmergable label Mar 11, 2016
@OlegHahm
Copy link
Member

Please squash

@jnohlgard jnohlgard force-pushed the pr/uart-stdio-defines branch from 5244a92 to dc303a4 Compare March 11, 2016 11:04
@jnohlgard
Copy link
Member Author

squashed, rebased on latest master

@OlegHahm OlegHahm removed the CI: needs squashing Commits in this PR need to be squashed; If set, CI systems will mark this PR as unmergable label Mar 11, 2016
@kaspar030
Copy link
Contributor

ACK. CI happy -> go.

kaspar030 added a commit that referenced this pull request Mar 11, 2016
@kaspar030
Merge pull request #5023 from gebart/pr/uart-stdio-defines
f6ee899 
sys/uart_stdio: Move macro definitions to header file, rename STDIO -> UART_STDIO_DEV
@kaspar030 kaspar030 merged commit f6ee899 into RIOT-OS:master Mar 11, 2016
@OlegHahm
Copy link
Member

Travis hasn't finished.

@jnohlgard jnohlgard deleted the pr/uart-stdio-defines branch March 12, 2016 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@OlegHahm OlegHahm

Labels
Area: drivers Area: Device drivers Area: network Area: Networking CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation
Projects
None yet
Milestone
Release 2016.04
Development

Successfully merging this pull request may close these issues.
3 participants
@jnohlgard @OlegHahm @kaspar030