boards/arduino-mega2560: cleanup in periph_conf.h #5021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haukepetersen
added
Platform: AVR
|
What about the added SPI? |
|
@OlegHahm I'll test it ASAP ;) |
|
I was more referring to the fact that this is not mentioned in the PR title or description. |
|
Ah, now I get it. Overlooked the #5020 in the description, because the label was not set. |
OlegHahm
added
the
State: waiting for other PR
|
Oh yes, there are two different PRs |
- remove unused periph configuration - fixed doxygen
haukepetersen
force-pushed
the
fix_arduinomega_periphconf
branch
from
f2b1221 to
e55ea08
Compare
haukepetersen
added
CI: ready for build
|
dependencies are in, ready for review. |
|
ACK and go |
kYc0o
added a commit
that referenced
this pull request
Mar 10, 2016
boards/arduino-mega2560: cleanup in periph_conf.h
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rebased on #5020removed some unused defines and cleaned up doxygen.