-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
travis: continue static tests on error #4948
Conversation
Not sure - @authmillenon, what do you think? |
what's the benefit of not running cppcheck if the doxycheck failed beforehand? (: |
Time. |
I disagree. IMO, it is much more time efficient to run them all in one slide instead of waiting for travis to enqueue the job again. |
Actually this is how this script is supposed to work. I do not know why the old solution did not work out (though I tried to debug multiple times). We don't save time if Travis is nitpicking over each time about a different thing and it's frustrating for new contributors. Just one question: what if the result is neither one nor zero? Is this also catched? |
Convinced. |
(I don't know how trap is working) |
@authmillenon the problem is that
trap on ERR will be fired for each non-zero exit code. And I just set Result to 1 in that case |
Then ACK. |
travis: continue static tests on error
Can someone confirm that this PR didn't break the logic? Murdock doesn't seem to exit on doc errors anymore. |
Continue static tests even if one of them fails. This way we might get more feedback in one run, instead of having a running - testing - running - testing loop.
In the current implementation the script exits as soon as one of static tests fail (because of
set -e
).