Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cpu/kinetis_common: Add periph/dac implementation #4814

Merged
merged 1 commit into from
Mar 23, 2016
Merged

cpu/kinetis_common: Add periph/dac implementation #4814

merged 1 commit into from
Mar 23, 2016

Conversation

jnohlgard
Copy link
Member

(depends on #4431)

A minimal DAC implementation for Kinetis.

@jnohlgard jnohlgard added Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation Platform: ARM Platform: This PR/issue effects ARM-based platforms State: waiting for other PR State: The PR requires another PR to be merged first labels Feb 14, 2016
@jnohlgard jnohlgard added this to the Release 2016.03 milestone Feb 14, 2016
@jnohlgard jnohlgard mentioned this pull request Feb 22, 2016
Closed
@jnohlgard jnohlgard mentioned this pull request Mar 11, 2016
Merged
@DipSwitch
Copy link
Member

Needs rebase.

@jnohlgard
Copy link
Member Author

rebased

@DipSwitch DipSwitch removed the State: waiting for other PR State: The PR requires another PR to be merged first label Mar 15, 2016
@DipSwitch
Copy link
Member

Would it be possible to refactor the code so it looks like the ADC implementation and uses a dac_conf_t ?

@haukepetersen
Copy link
Contributor

I am with @DipSwitch here: I am strictly against moving peripheral drivers that use the old ifdef endif ifdef endif paradigm.

@DipSwitch
Copy link
Member

ACK

Looks good, please squash :)

@DipSwitch DipSwitch added the CI: needs squashing Commits in this PR need to be squashed; If set, CI systems will mark this PR as unmergable label Mar 19, 2016
@jnohlgard
Copy link
Member Author

squashed

@jnohlgard jnohlgard added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: needs squashing Commits in this PR need to be squashed; If set, CI systems will mark this PR as unmergable CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Mar 19, 2016
@DipSwitch DipSwitch added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Mar 20, 2016
@DipSwitch
Copy link
Member

Some build errors

@jnohlgard jnohlgard added the CI: needs squashing Commits in this PR need to be squashed; If set, CI systems will mark this PR as unmergable label Mar 21, 2016
@jnohlgard
Copy link
Member Author

Moved dac_config array to dac.c

@jnohlgard
Copy link
Member Author

OK to squash?
(Murdock passed except the needs squashing part)

@DipSwitch
Copy link
Member

Fine by me, looks good :)

@jnohlgard
Copy link
Member Author

rebased, squashed

@jnohlgard jnohlgard removed the CI: needs squashing Commits in this PR need to be squashed; If set, CI systems will mark this PR as unmergable label Mar 22, 2016
@DipSwitch DipSwitch added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Mar 22, 2016
@cgundogan
Copy link
Member

was ACKed and both CIs are happy => GO

@cgundogan cgundogan merged commit 551cb33 into RIOT-OS:master Mar 23, 2016
@jnohlgard jnohlgard deleted the pr/kinetis-dac branch March 29, 2016 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@haukepetersen haukepetersen

Labels
CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: ARM Platform: This PR/issue effects ARM-based platforms Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation
Projects
None yet
Milestone
Release 2016.04
Development

Successfully merging this pull request may close these issues.
4 participants
@jnohlgard @DipSwitch @haukepetersen @cgundogan