Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drivers/mma8652: pba-d-01-kw2x: add support for SAUL #4783

Merged
merged 5 commits into from
Mar 21, 2016
Merged

drivers/mma8652: pba-d-01-kw2x: add support for SAUL #4783

merged 5 commits into from
Mar 21, 2016

Conversation

cgundogan
Copy link
Member

This PR adds SAUL support for the mma8652 accelerometer and the pba-d-01-kw2x board.
Can be tested with the default example and then call saul 0 read.

@cgundogan cgundogan added Type: new feature The issue requests / The PR implemements a new feature for RIOT Area: drivers Area: Device drivers labels Feb 10, 2016
jnohlgard
jnohlgard reviewed Feb 13, 2016
View reviewed changes
sys/auto_init/saul/auto_init_mma8652.c
*
*/

/*
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing doxygen opening tag (/**)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch. Amended the change.

@cgundogan cgundogan force-pushed the pr/pba-d-01-kw2x/saul_mma8652 branch 2 times, most recently from 6574b25 to a8191d7 Compare February 13, 2016 09:55
@OlegHahm
Copy link
Member

@cgundogan, needs a rebase.

@cgundogan cgundogan force-pushed the pr/pba-d-01-kw2x/saul_mma8652 branch from a8191d7 to 558c40e Compare February 27, 2016 19:34
@cgundogan cgundogan added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Feb 27, 2016
@cgundogan
Copy link
Member Author

rebased

@cgundogan cgundogan force-pushed the pr/pba-d-01-kw2x/saul_mma8652 branch 3 times, most recently from 63309e5 to e2ccdab Compare March 3, 2016 14:56
@cgundogan
Copy link
Member Author

rebased, again

@OlegHahm OlegHahm added this to the Release 2016.04 milestone Mar 6, 2016
@cgundogan
Copy link
Member Author

@haukepetersen wanna review? (:

@cgundogan cgundogan force-pushed the pr/pba-d-01-kw2x/saul_mma8652 branch from e2ccdab to 7d35c06 Compare March 21, 2016 15:16
@haukepetersen
Copy link
Contributor

Code looks good, works as expected, CI is happy -> ACK and go.

haukepetersen added a commit that referenced this pull request Mar 21, 2016
@haukepetersen
Merge pull request #4783 from cgundogan/pr/pba-d-01-kw2x/saul_mma8652
a037587 
drivers/mma8652: pba-d-01-kw2x: add support for SAUL
@haukepetersen haukepetersen merged commit a037587 into RIOT-OS:master Mar 21, 2016
@cgundogan cgundogan deleted the pr/pba-d-01-kw2x/saul_mma8652 branch March 21, 2016 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@haukepetersen haukepetersen

Labels
Area: drivers Area: Device drivers CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: new feature The issue requests / The PR implemements a new feature for RIOT
Projects
None yet
Milestone
Release 2016.04
Development

Successfully merging this pull request may close these issues.
4 participants
@cgundogan @OlegHahm @haukepetersen @jnohlgard