drivers: add ethernet over serial driver #4438

kaspar030 · 2015-12-08T13:34:24Z

I needed a one-cable solution for connecting boards with both network and console. So I came up with this driver, which is essentially l2 SLIP and additional support for multiplexing STDIO over the same serial connection.

It is an alternative to gnrc_slip / tuntap.

Differences:

it implements a netdev driver
it transfers l2 ethernet frames instead of IP packets
it enables network and stdio over just one serial cable
it uses a slightly more robust framing
it is more code
it is only tested on Linux
it uses more memory
it has slower ping times

The last two will probably be fixed.

In order to play with it, see dist/tools/ethos/README.md for what to add to your makefiles.

OlegHahm · 2015-12-08T15:21:57Z

Cool, that could help to run a 6LBR on the IoT-LAB testbed.

cladmi · 2015-12-09T11:13:54Z

I also thought that the shell could also be available as a server. This way, the multiplexing would directly use the network stack.

It would just needed to set the first ip address automatically and print in on the serial line like as done in contiki examples.

miri64 · 2015-12-09T11:25:55Z

did not look into your implementation in detail, but shouldn't it be way simpler to just multiplex slip and shell input/output over one UART?

kaspar030 · 2015-12-09T11:28:09Z

I also thought that the shell could also be available as a server. This way, the multiplexing would directly use the network stack.

... which in turn would make it impossible to debug the network stack edit using stdio.

kaspar030 · 2015-12-09T11:32:18Z

did not look into your implementation in detail, but shouldn't it be way simpler to just multiplex slip and shell input/output over one UART?

It would end up being the same but on Layer 3 in principal, which honestly I realized when taking a look at how you did some things in gnrc_slip.

But ethos is also netdev based and thus works without gnrc.

miri64 · 2015-12-09T11:46:34Z

Ah, I missed the non-gnrc part :-)

miri64 · 2015-12-09T11:49:26Z

drivers/ethos/ethos.c

+    tsrb_init(&dev->inbuf, (char*)buf, bufsize);
+    mutex_init(&dev->out_mutex);
+
+    uint32_t a = genrand_uint32();


I already hate the fact, that netdev2_tap has more or less random MAC addresses, but at least they are somewhat stable as long as you don't rebuild the TAP. Can't you use the CPUID to generate the MAC? It would make debugging and testing with these devices way easier ;-).

Also keep in mind that bits 7 (U/L) and 8 (I/G) have special meaning in 48-bit MAC addresses http://standards.ieee.org/develop/regauth/tut/eui.pdf

(address is globally unique if bit 7 is unset [so you need to set it, since you generated it], bit 8 needs to be unset since your address is a unicast address)

Totally. Will fix.

@kaspar030 do you have time to address @authmillenon's comment until the Hack'n'Ack session?

emmanuelsearch · 2016-01-25T15:42:34Z

Is this too WIP to be an H&A candidate? Arguably it is a new functionality that could be improved later too... right?

kYc0o · 2016-01-25T15:45:08Z

Hey! I was about to ask the same, if I can ACK this PR let me know

cgundogan · 2016-01-25T15:47:25Z

@emmanuelsearch I used this feature several times with great success. I would also vote for getting this merged as soon as @kaspar030 addressed @authmillenon's comments. I couldn't get ethos to work with the iotlab-testbed, though. I am not sure if this is due to ethos or whether it is some magic that I am unaware of when I tunnel the serial aggregator to my local machine in order to use it with ethos. @kaspar030 I'd like to talk to you about this f2f if you attend tomorrow's H&A.

emmanuelsearch · 2016-01-25T15:47:32Z

@kYc0o did you already test this? On which hardware/config?

emmanuelsearch · 2016-01-25T15:51:04Z

@cgundogan you used successfully this with SAMR21, I suppose?

cgundogan · 2016-01-25T15:52:21Z

yes, the typical scenario: samr21-xpro running the border router example

kYc0o · 2016-01-25T15:53:36Z

I didn't already test but I plan to do it as soon as possible on IoT-Lab

thomaseichinger · 2016-01-25T15:54:59Z

dist/tools/ethos/ethos.c

+
+#include <netinet/in.h>
+#include <linux/if.h>
+#include <linux/if_tun.h>


Please mention in the README or somewhere else this is only usable with linux.

cgundogan · 2016-01-25T17:06:57Z

interesting - tested with iotlab-m3 and I didn't receive any output from ethos. Tried with samr21-xpro afterwards and there was also no output from ethos. Will check more thoroughly tomorrow

kaspar030 · 2016-01-26T11:09:57Z

addressed comments

kaspar030 · 2016-01-26T11:10:27Z

I had some trouble using this on a uclibc-based OpenWrt as host.

kaspar030 · 2016-01-26T13:09:12Z

I just realized that ethos doesn't work until I've used the board once using "make term". Probably something is missing in ethos' linux side terminal setup.

kaspar030 · 2016-02-03T19:21:47Z

I ACK this PR too. However, please notice this https://lists.riot-os.org/pipermail/devel/2016-February/003386.html since I had the same issue.

RIOT doesn't answer to pings for addresses that were not the interface the echo request came in. See #4456.

OlegHahm · 2016-02-03T19:47:35Z

Confirmed.

kaspar030 · 2016-02-04T16:18:06Z

fixed stupid bug on linux side, rebased

kYc0o · 2016-02-04T17:09:58Z

Now is also working on my side. I think if travis is happy the PR can be merged

kaspar030 · 2016-02-04T17:28:34Z

I'll have to squash first...

kaspar030 · 2016-02-05T11:55:01Z

squashed

kaspar030 · 2016-02-05T17:53:51Z

Travis seem lazy. :)

OlegHahm · 2016-02-06T11:43:49Z

>file has an unknown license header: 'dist/tools/ethos/ethos.c'

kaspar030 · 2016-02-07T18:17:40Z

fixed license header problem, doxygen, static code checker nitpicks

kaspar030 · 2016-02-07T23:08:09Z

Mr. T. is all green. Anyone cares to say ACK and press merge?

kYc0o · 2016-02-07T23:08:55Z

ACK :)

drivers: add ethernet over serial driver

kaspar030 assigned cgundogan Dec 8, 2015

OlegHahm modified the milestone: Release 2016.03 Dec 8, 2015

miri64 reviewed Dec 9, 2015
View reviewed changes

kaspar030 force-pushed the add_eth_over_serial branch from fc09427 to 713a369 Compare December 21, 2015 14:21

thomaseichinger reviewed Jan 25, 2016
View reviewed changes

kaspar030 force-pushed the add_eth_over_serial branch from 713a369 to 665786c Compare January 26, 2016 11:08

kaspar030 force-pushed the add_eth_over_serial branch from 44a5243 to 871add0 Compare February 4, 2016 16:16

kYc0o added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Feb 4, 2016

OlegHahm added the CI: needs squashing Commits in this PR need to be squashed; If set, CI systems will mark this PR as unmergable label Feb 4, 2016

kaspar030 force-pushed the add_eth_over_serial branch from 871add0 to dce8927 Compare February 5, 2016 11:54

kaspar030 removed CI: needs squashing Commits in this PR need to be squashed; If set, CI systems will mark this PR as unmergable Discussion: RFC The issue/PR is used as a discussion starting point about the item of the issue/PR labels Feb 5, 2016

kYc0o added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Feb 5, 2016

kaspar030 force-pushed the add_eth_over_serial branch from dce8927 to fa15d31 Compare February 5, 2016 17:52

kaspar030 force-pushed the add_eth_over_serial branch from fa15d31 to ecf70f3 Compare February 5, 2016 18:33

kaspar030 added 3 commits February 7, 2016 19:15

drivers: net: add ethos (ethernet over serial) driver

9e3e485

dist: add ethos UNIX tool

52aec3a

dist/tools/licenses: add GPLv2 short pattern

c762a6f

kaspar030 force-pushed the add_eth_over_serial branch from 63327ee to c762a6f Compare February 7, 2016 18:17

kYc0o added a commit that referenced this pull request Feb 7, 2016

Merge pull request #4438 from kaspar030/add_eth_over_serial

66dab58

drivers: add ethernet over serial driver

kYc0o merged commit 66dab58 into RIOT-OS:master Feb 7, 2016

kaspar030 deleted the add_eth_over_serial branch February 8, 2016 09:56

kaspar030 mentioned this pull request Feb 8, 2016

drivers: ethos needs OS X support #4764

Closed

miri64 mentioned this pull request Mar 8, 2016

examples/gnrc_border_router: Add ethos and start_network.sh to README.md #4996

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

drivers: add ethernet over serial driver #4438

drivers: add ethernet over serial driver #4438

kaspar030 commented Dec 8, 2015

OlegHahm commented Dec 8, 2015

cladmi commented Dec 9, 2015

miri64 commented Dec 9, 2015

kaspar030 commented Dec 9, 2015

kaspar030 commented Dec 9, 2015

miri64 commented Dec 9, 2015

miri64 Dec 9, 2015

miri64 Dec 9, 2015

miri64 Dec 9, 2015

kaspar030 Dec 9, 2015

cgundogan Jan 25, 2016

emmanuelsearch commented Jan 25, 2016

kYc0o commented Jan 25, 2016

cgundogan commented Jan 25, 2016

emmanuelsearch commented Jan 25, 2016

emmanuelsearch commented Jan 25, 2016

cgundogan commented Jan 25, 2016

kYc0o commented Jan 25, 2016

thomaseichinger Jan 25, 2016

cgundogan commented Jan 25, 2016

kaspar030 commented Jan 26, 2016

kaspar030 commented Jan 26, 2016

kaspar030 commented Jan 26, 2016

kaspar030 commented Feb 3, 2016

OlegHahm commented Feb 3, 2016

kaspar030 commented Feb 4, 2016

kYc0o commented Feb 4, 2016

kaspar030 commented Feb 4, 2016

kaspar030 commented Feb 5, 2016

kaspar030 commented Feb 5, 2016

OlegHahm commented Feb 6, 2016

kaspar030 commented Feb 7, 2016

kaspar030 commented Feb 7, 2016

kYc0o commented Feb 7, 2016

drivers: add ethernet over serial driver #4438

drivers: add ethernet over serial driver #4438

Conversation

kaspar030 commented Dec 8, 2015

OlegHahm commented Dec 8, 2015

cladmi commented Dec 9, 2015

miri64 commented Dec 9, 2015

kaspar030 commented Dec 9, 2015

kaspar030 commented Dec 9, 2015

miri64 commented Dec 9, 2015

miri64 Dec 9, 2015

Choose a reason for hiding this comment

miri64 Dec 9, 2015

Choose a reason for hiding this comment

miri64 Dec 9, 2015

Choose a reason for hiding this comment

kaspar030 Dec 9, 2015

Choose a reason for hiding this comment

cgundogan Jan 25, 2016

Choose a reason for hiding this comment

emmanuelsearch commented Jan 25, 2016

kYc0o commented Jan 25, 2016

cgundogan commented Jan 25, 2016

emmanuelsearch commented Jan 25, 2016

emmanuelsearch commented Jan 25, 2016

cgundogan commented Jan 25, 2016

kYc0o commented Jan 25, 2016

thomaseichinger Jan 25, 2016

Choose a reason for hiding this comment

cgundogan commented Jan 25, 2016

kaspar030 commented Jan 26, 2016

kaspar030 commented Jan 26, 2016

kaspar030 commented Jan 26, 2016

kaspar030 commented Feb 3, 2016

OlegHahm commented Feb 3, 2016

kaspar030 commented Feb 4, 2016

kYc0o commented Feb 4, 2016

kaspar030 commented Feb 4, 2016

kaspar030 commented Feb 5, 2016

kaspar030 commented Feb 5, 2016

OlegHahm commented Feb 6, 2016

kaspar030 commented Feb 7, 2016

kaspar030 commented Feb 7, 2016

kYc0o commented Feb 7, 2016