Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: move thread flags from flags.h to thread.h #4382

Merged
merged 8 commits into from
Dec 8, 2015
Merged

core: move thread flags from flags.h to thread.h #4382

merged 8 commits into from
Dec 8, 2015

Conversation

haukepetersen
Copy link
Contributor

fixes #4338

@haukepetersen haukepetersen added Area: core Area: RIOT kernel. Handle PRs marked with this with care! Impact: major The PR changes a significant part of the code base. It should be reviewed carefully Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation labels Dec 2, 2015
@haukepetersen haukepetersen added this to the Release 2015.12 milestone Dec 2, 2015
Kijewski
Kijewski reviewed Dec 2, 2015
View reviewed changes
core/include/thread.h
/**
* @brief Currently not implemented
*/
#define THREAD_AUTO_FREE (2)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just drop it and forget about it, maybe?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had the same in mind, but I think it makes sense to do this in a separate PR - so my plan was to merge this first and open a second one afterwards

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right. Should be a PR on its own.

@kaspar030 kaspar030 added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Process: API change Integration Process: PR contains or issue proposes an API change. Should be handled with care. and removed Impact: major The PR changes a significant part of the code base. It should be reviewed carefully labels Dec 2, 2015
@kaspar030
Copy link
Contributor

looks good to me. 1st ACK.

@haukepetersen
Copy link
Contributor Author

@OlegHahm, @thomaseichinger, @Kijewski: one of you up to giving a 2nd ack?

@OlegHahm
Copy link
Member

OlegHahm commented Dec 7, 2015

needs a rebase

@kaspar030
Copy link
Contributor

@haukepetersen ping

@OlegHahm OlegHahm modified the milestone: Release 2015.12 Dec 7, 2015
@haukepetersen
Copy link
Contributor Author

rebased

@OlegHahm
Copy link
Member

OlegHahm commented Dec 7, 2015

I don't really like the long macro names, but I agree that this change makes sense and the new names are actually more aligned with our naming convention. ACK.

@haukepetersen
Copy link
Contributor Author

rebased and adapted the new gnrc_tftp example

@haukepetersen
Copy link
Contributor Author

Travis is happy and we have 2 ACKs -> go

haukepetersen added a commit that referenced this pull request Dec 8, 2015
@haukepetersen
Merge pull request #4382 from haukepetersen/rm_core_flagsh
cf53aed 
core: move thread flags from flags.h to thread.h
@haukepetersen haukepetersen merged commit cf53aed into RIOT-OS:master Dec 8, 2015
@haukepetersen haukepetersen deleted the rm_core_flagsh branch December 8, 2015 10:36
@OlegHahm
Copy link
Member

OlegHahm commented Dec 8, 2015

Dman, should have thought about it. Now I have to rebase again.

@haukepetersen
Copy link
Contributor Author

sorry :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@kaspar030 kaspar030

Labels
Area: core Area: RIOT kernel. Handle PRs marked with this with care! CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Process: API change Integration Process: PR contains or issue proposes an API change. Should be handled with care. Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation
Projects
None yet
Milestone
Release 2015.12
Development

Successfully merging this pull request may close these issues.

move thread flags from flags.h to thread.h
4 participants
@haukepetersen @kaspar030 @OlegHahm @Kijewski