sys/auto_init: fix stack size for encx24j600 stack #4208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haukepetersen
added
Type: bug
|
@haukepetersen Are you aware that DEBUG_EXTRA_STACKSIZE evaluates to 0 if ENABLE_DEBUG==0? |
|
nope :-) But adding it to the stack twice, was that intentional? |
|
no, not at all. ;) |
|
Alright then, are you willing to merge this as-is or should I revert the first change? |
Yes, please. The extra_stacksize is there so that it gets added when someone sets enable_debug, it is completely intentional. Only adding it twice was not. |
haukepetersen
force-pushed
the
fix_ainit_encx24
branch
from
3414204 to
9052a09
Compare
haukepetersen
added
the
CI: ready for build
|
I see -> adapted |
|
ACK. |
kaspar030
added a commit
that referenced
this pull request
Nov 3, 2015
sys/auto_init: fix stack size for encx24j600 stack
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think
THREAD_STACKSIZE_DEFAULTshould be sufficient here. But it is definitely not default + 2*extra...