network_layer: remove last occurences of vtimer #4186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgundogan
added
Type: enhancement
cgundogan
added
the
CI: ready for build
|
Can you also replace the last occurrences of |
| @@ -24,7 +24,6 @@ | |||
| #include "net/gnrc/sixlowpan/nd.h" | |||
| #include "thread.h" | |||
| #include "timex.h" | |||
| #include "vtimer.h" | |||
There was a problem hiding this comment.
+#include "xtimer.h"?
(below too?)
There was a problem hiding this comment.
xtimer.h gets included by other header files AFAICS and is not needed here
There was a problem hiding this comment.
Transitive includes: Guaranteed future weird build errors ;).
sure, will do that in a follow-up PR |
|
@authmillenon addressed your comment |
|
ACK. |
miri64
added
the
CI: needs squashing
cgundogan
force-pushed
the
pr/ipv6/last_vtimers
branch
from
7d5d7fc to
5fb1041
Compare
|
squashed |
cgundogan
removed
the
CI: needs squashing
|
travis agrees - GO |
cgundogan
added a commit
that referenced
this pull request
Nov 2, 2015
network_layer: remove last occurences of vtimer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes further occurences of vtimer by replacing them with xtimer in
gnrc_icmpv6,gnrc_ipv6,gnrc_ndpandgnrc_sixlowpan