Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unittests: initialize xtimer if present #4100

Merged
merged 1 commit into from
Nov 6, 2015
Merged

unittests: initialize xtimer if present #4100

merged 1 commit into from
Nov 6, 2015

Conversation

miri64
Copy link
Member

@miri64 miri64 commented Oct 15, 2015

Fixes #4095.

@miri64 miri64 added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Oct 15, 2015
jnohlgard
jnohlgard reviewed Oct 15, 2015
View reviewed changes
tests/unittests/main.c
@@ -21,6 +22,10 @@

int main(void)
{
#ifdef MODULE_XTIMER
xtimer_init();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a comment in code why we run this here (auto-init is disabled in unittests, and modules depending on xtimer expect it to be initialized)

@OlegHahm OlegHahm added this to the Release 2015.12 milestone Oct 22, 2015
@jnohlgard jnohlgard added the CI: needs squashing Commits in this PR need to be squashed; If set, CI systems will mark this PR as unmergable label Oct 29, 2015
@jnohlgard
Copy link
Member

ACK, please squash

@miri64 miri64 removed the CI: needs squashing Commits in this PR need to be squashed; If set, CI systems will mark this PR as unmergable label Oct 29, 2015
@miri64
Copy link
Member Author

miri64 commented Oct 29, 2015

Squashed

jnohlgard pushed a commit that referenced this pull request Nov 6, 2015
Merge pull request #4100 from authmillenon/tests/fix/i4095
6378be1 
unittests: initialize xtimer if present
@jnohlgard jnohlgard merged commit 6378be1 into RIOT-OS:master Nov 6, 2015
@miri64 miri64 deleted the tests/fix/i4095 branch November 11, 2015 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jnohlgard jnohlgard

Labels
Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Milestone
Release 2015.12
Development

Successfully merging this pull request may close these issues.
3 participants
@miri64 @jnohlgard @OlegHahm