boards: remove header guard under scores #3056
Conversation
OlegHahm
added
CI: needs squashing
| #define M (((PLL0CFG_Val ) & 0x7FFF) + 1) | ||
| #define N (((PLL0CFG_Val >> 16) & 0x00FF) + 1) | ||
| #define FCCO(__F_IN) ((2ULL * M * __F_IN) / N) | ||
| #define CCLK_DIV (((CCLKCFG_Val ) & 0x00FF) + 1) |
There was a problem hiding this comment.
Because it's not a header guard? But we don't want leading underscores in any macro, right? So, I would just update the commit message.
There was a problem hiding this comment.
Partly, yes, partly because I have now idea about mbed_lpc1768. These look like board-lib vars.
There was a problem hiding this comment.
#define-ing one letter names like N etc leads to incredibly difficult to understand compile problems when a new user writes their program to use the variable N for something.
There was a problem hiding this comment.
nevermind, this is inside a .c file, not a header.
There was a problem hiding this comment.
Yes, I took this into account. :)
|
found some more forgotten stuff and inconsistencies. Also I marked some parts with broken comment styling. I know they are not really part of this PR, but why not fix them while you are at it... |
|
Addressed comments. |
|
Looks good to me. ACK when Travis is happy. |
|
(Needs squashing first) |
| @@ -27,7 +27,7 @@ | |||
| extern "C" { | |||
| #endif | |||
|
|
|||
| #define F_CPU (24000000) ///< CPU target speed in Hz | |||
| #define F_CPU (24000000) /* /< CPU target speed in Hz */ | |||
|
I went through all changes and commented where I could spot any mistakes. This should be ready after my comments are addressed. |
|
addressed comments |
|
Please squash. |
| @@ -19,4 +19,4 @@ void init_display_putchar(void); | |||
| } | |||
| #endif | |||
|
|
|||
| #endif /* __DISPLAY_PUTCHAR_H */ | |||
| #endif /* DISPLAY_PUTCHAR_H */ | |||
There was a problem hiding this comment.
Nitpick: wrong macro name in comment
|
I can only find small nitpicks now. I think this is ready for merging. ACK, please squash. Merge when Travis is happy. |
|
Addressed @gebart's nitpicking. 😉 |
|
ACK, squash and go when Travis is fine. |
* also added a trailing underscore to header guards for consistency Commit for PR 2623, repairing header file include guards. This PR is intended to fix the include guards in files under RIOT/boards SQUASH ME: fix underscore removal overdos SQUASH ME: consistent macro naming SQUASH ME: missed that one SQUASH ME: fixed overdo SQUASH ME: consistency
OlegHahm
force-pushed
the
board_leading_underscore_removal
branch
from
c4737bd to
8c203a6
Compare
OlegHahm
added
CI: ready for build
|
Squashed. |
|
kicked Travis |
|
ACK |
boards: remove header guard under scores
This replaces #2858