Docker: allow buildtests inside Docker, refactor environment handling. #2923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 6, 2015 14:03
- Better support for passing environment variables to the Docker container. - Move Docker-related definitions into Makefile.docker. - Only environment variables that originates from the command line or the environment will be passed to the Docker container.
jnohlgard
added
Type: enhancement
|
kicked Travis |
|
looks good to me. |
|
& go! |
jnohlgard
pushed a commit
that referenced
this pull request
May 8, 2015
Docker: allow buildtests inside Docker, refactor environment handling.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the environment handling for Docker builds to remove the need for passing
__RIOTBUILD_FLAGto the Docker environment by only passing variables which have been set outside of the Makefiles (environment, command line).The second commit adds
buildtestas a supported target for building inside a Docker container.