Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cpu/cc2538: avoid using bitfields with the LCRH register #2753

Merged
merged 1 commit into from
Mar 2, 2016
Merged

cpu/cc2538: avoid using bitfields with the LCRH register #2753

merged 1 commit into from
Mar 2, 2016

Conversation

hexluthor
Copy link
Contributor

Otherwise the UART ignores the new baudrate divisor. Tested on cc2538dk with various SYS_DIV (system clock rate) settings.

@PeterKietzmann
Copy link
Member

Looks reasonable. Has anyone the hardware to test? I don't...

@OlegHahm OlegHahm added the Platform: ARM Platform: This PR/issue effects ARM-based platforms label Apr 9, 2015
@OlegHahm
Copy link
Member

OlegHahm commented Apr 9, 2015

Me neither. Should we just merge?

@PeterKietzmann
Copy link
Member

I'd say yes but I don't dare to do so :-)

@OlegHahm
Copy link
Member

OlegHahm commented May 9, 2015

@haukepetersen, can you test?

@haukepetersen
Copy link
Contributor

yes, will ASAP (sorry for the delay)

@OlegHahm OlegHahm modified the milestone: Release 2016.03 Dec 8, 2015
@OlegHahm OlegHahm assigned kYc0o and unassigned haukepetersen Feb 26, 2016
@OlegHahm
Copy link
Member

@hexluthor, can you rebase? @kYc0o, you have the hardware to test, right?

@kYc0o
Copy link
Contributor

kYc0o commented Feb 26, 2016

Yes I can test :)

@hexluthor
cpu/cc2538: avoid using bitfields with the LCRH register
04bd6e5 
Otherwise the UART ignores the new baudrate divisor.
@hexluthor
Copy link
Contributor Author

Rebased.

@OlegHahm
Copy link
Member

Cool!

@kYc0o kYc0o added Community: Hack'n'ACK candidate This PR is a candidate for review and discussion during one of RIOT's monthly Hack'n'ACK parties CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Feb 28, 2016
@kYc0o
Copy link
Contributor

kYc0o commented Mar 1, 2016

I just tested with sucess, just waiting for travis.

@miri64
Copy link
Member

miri64 commented Mar 1, 2016

@kYc0o I give you the honor to merge this ;)

@kYc0o
Copy link
Contributor

kYc0o commented Mar 2, 2016

hohoho I was very optimistic with the T-guy xD

@OlegHahm
Copy link
Member

OlegHahm commented Mar 2, 2016

@kYc0o, wanna give it another try with merging? ;-)

@kYc0o
Copy link
Contributor

kYc0o commented Mar 2, 2016

wow! It has just finished? I was looking at it every 5min! yes! ACK and merge!

kYc0o added a commit that referenced this pull request Mar 2, 2016
@kYc0o
Merge pull request #2753 from locicontrols/baudrate-fix
ec1bea3 
cpu/cc2538: avoid using bitfields with the LCRH register
@kYc0o kYc0o merged commit ec1bea3 into RIOT-OS:master Mar 2, 2016
@OlegHahm
Copy link
Member

OlegHahm commented Mar 2, 2016

Yeah!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@kYc0o kYc0o

Labels
CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Community: Hack'n'ACK candidate This PR is a candidate for review and discussion during one of RIOT's monthly Hack'n'ACK parties Platform: ARM Platform: This PR/issue effects ARM-based platforms
Projects
None yet
Milestone
Release 2016.04
Development

Successfully merging this pull request may close these issues.
6 participants
@hexluthor @PeterKietzmann @OlegHahm @haukepetersen @kYc0o @miri64