Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

boards/nucleo-f334: indicate periph_cpuid feature #2599

Merged
merged 1 commit into from
Mar 19, 2015
Merged

boards/nucleo-f334: indicate periph_cpuid feature #2599

merged 1 commit into from
Mar 19, 2015

Conversation

LudwigKnuepfer
Copy link
Member

Follow up to #2552 by @jhollister

@LudwigKnuepfer LudwigKnuepfer added the Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation label Mar 14, 2015
@haukepetersen
Copy link
Contributor

works as expected. I would prefer to list every future in it's own line of code:

FEATURES_PROVIDED += periph_cpuid 
FEATURES_PROVIDED += periph_uart
FEATURES_PROVIDED += cpp
FEATURES_MCU_GROUP = cortex_m4

This prevents the collisions on some occasions and saves us some rebasing efforts (also opened an issue for this -> #2611)

@LudwigKnuepfer LudwigKnuepfer force-pushed the pr/nucleo-f334-periph-cpuid branch from ae659a3 to 14063d2 Compare March 16, 2015 20:46
@LudwigKnuepfer
Copy link
Member Author

Amended the change.

@thomaseichinger
Copy link
Member

ACK when Travis passed.

@haukepetersen
Copy link
Contributor

kicked Travis

LudwigKnuepfer added a commit that referenced this pull request Mar 19, 2015
@LudwigKnuepfer
Merge pull request #2599 from LudwigOrtmann/pr/nucleo-f334-periph-cpuid
54020a1 
boards/nucleo-f334: indicate periph_cpuid feature
@LudwigKnuepfer LudwigKnuepfer merged commit 54020a1 into RIOT-OS:master Mar 19, 2015
@LudwigKnuepfer LudwigKnuepfer deleted the pr/nucleo-f334-periph-cpuid branch March 19, 2015 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@thomaseichinger thomaseichinger

Labels
Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LudwigKnuepfer @haukepetersen @thomaseichinger