sys/event: add event loop debug threshold #21763

kfessel · 2025-10-06T16:08:46Z

Contribution description

provide a configurable threshold value for printing event handler run time

Testing procedure

Issues/PRs references

benpicco · 2025-10-06T16:59:43Z

sys/include/event.h

+ *        Use this to prevent *a lot* of output when debugging.
+ */
+#ifndef CONFIG_EVENT_LOOP_DEBUG_THRESHOLD
+#define CONFIG_EVENT_LOOP_DEBUG_THRESHOLD  (0)


Suggested change

#define CONFIG_EVENT_LOOP_DEBUG_THRESHOLD (0)

#define CONFIG_EVENT_LOOP_DEBUG_THRESHOLD_US (0)

Suggested change

#define CONFIG_EVENT_LOOP_DEBUG_THRESHOLD (0)

# define CONFIG_EVENT_LOOP_DEBUG_THRESHOLD_US (0)

Also indentation 👀

benpicco · 2025-10-06T17:00:51Z

sys/include/event.h

+            uint32_t now2 = ztimer_now(ZTIMER_USEC);
+            uint32_t dt = now2 - now;


Suggested change

uint32_t now2 = ztimer_now(ZTIMER_USEC);

uint32_t dt = now2 - now;

uint32_t dt = ztimer_now(ZTIMER_USEC) - now;

crasbe · 2025-10-06T18:15:19Z

sys/include/event.h

+
+            if ((CONFIG_EVENT_LOOP_DEBUG_THRESHOLD == 0) ||
+                dt > CONFIG_EVENT_LOOP_DEBUG_THRESHOLD) {
+                printf("eventh: %p took %" PRIu32 " µs\n",


Suggested change

printf("eventh: %p took %" PRIu32 " µs\n",

printf("event: %p took %" PRIu32 " µs\n",

Typo.

Also I'm not sure if using the actual Mu sign is a good idea, it may not work with some terminal programs. It's probably safer to use us.

changing the mu -> u

the h was because i changed fro event to handler being printed

how about:
'event: %p handler: %p queue: %p took:" PRIu32 "usec\n'

crasbe · 2025-10-06T18:15:48Z

sys/include/event.h

+ *        Use this to prevent *a lot* of output when debugging.
+ */
+#ifndef CONFIG_EVENT_LOOP_DEBUG_THRESHOLD
+#define CONFIG_EVENT_LOOP_DEBUG_THRESHOLD  (0)


Suggested change

#define CONFIG_EVENT_LOOP_DEBUG_THRESHOLD (0)

# define CONFIG_EVENT_LOOP_DEBUG_THRESHOLD_US (0)

Also indentation 👀

crasbe · 2025-10-06T18:18:44Z

sys/include/event.h

+ * @brief Threshold (USEC) below which event_handler are not printed,
+ *        while debugging eventloop setting a value (!0) will also remove
+ *        event_handler start message


Suggested change

* @brief Threshold (USEC) below which event_handler are not printed,

* while debugging eventloop setting a value (!0) will also remove

* event_handler start message

* @brief Threshold in microseconds below which event_handler

* are not printed.

*

* This can be used for debugging event loops. Setting a value

* other than zero will also remove the event_handler start message,

Perhaps a little clearer?

setting a value (!0) will also remove event_handler start message looks easier to read it especially uses less chars to express the case where one should not even set a value ( but rely on the default)

the actual sentence is: setting a value will also remove event_handler start message <supersmall> other than 0

changed it anyway

crasbe · 2025-10-06T18:19:42Z

sys/include/event.h

            }
            now = ztimer_now(ZTIMER_USEC);
-
+            void * h =  event->handler;


Suggested change

void * h = event->handler;

void *h = event->handler;

crasbe · 2025-10-06T18:20:59Z

sys/include/event.h

+            if ((CONFIG_EVENT_LOOP_DEBUG_THRESHOLD == 0) ||
+                dt > CONFIG_EVENT_LOOP_DEBUG_THRESHOLD) {
+                printf("eventh: %p took %" PRIu32 " µs\n",
+                       (void *)h, dt);


I'm not quite sure why you're casting h here, it already has the type void * 🤔

i probably first just used event->handler -> needed the cast but then saw the events might change -> h was born

riot-ci · 2025-10-06T19:44:41Z

Murdock results

✔️ PASSED

d888d46 sys/event: clang-format

Success	Failures	Total	Runtime
10516	0	10516	15m:14s

Artifacts

Documentation preview

github-actions bot added the Area: sys Area: System label Oct 6, 2025

kfessel force-pushed the p-eventloop-dbg branch 2 times, most recently from 58536de to 4d884bf Compare October 6, 2025 16:49

benpicco reviewed Oct 6, 2025

View reviewed changes

crasbe added Type: new feature The issue requests / The PR implemements a new feature for RIOT CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Oct 6, 2025

crasbe reviewed Oct 6, 2025

View reviewed changes

kfessel force-pushed the p-eventloop-dbg branch 2 times, most recently from 27fd3d7 to ddfbabb Compare October 6, 2025 19:40

kfessel force-pushed the p-eventloop-dbg branch from ddfbabb to 79ef710 Compare October 6, 2025 19:47

kfessel added 2 commits October 6, 2025 21:55

sys/event: add event loop debug threshold

964357a

sys/event: clang-format

d888d46

kfessel force-pushed the p-eventloop-dbg branch from 79ef710 to d888d46 Compare October 6, 2025 19:55

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

sys/event: add event loop debug threshold #21763

sys/event: add event loop debug threshold #21763

kfessel commented Oct 6, 2025

Uh oh!

benpicco Oct 6, 2025

Uh oh!

crasbe Oct 6, 2025

Uh oh!

benpicco Oct 6, 2025

Uh oh!

crasbe Oct 6, 2025

Uh oh!

kfessel Oct 6, 2025

Uh oh!

crasbe Oct 6, 2025

Uh oh!

crasbe Oct 6, 2025

Uh oh!

kfessel Oct 6, 2025 •

edited

Loading

Uh oh!

crasbe Oct 6, 2025

Uh oh!

crasbe Oct 6, 2025

Uh oh!

kfessel Oct 6, 2025

Uh oh!

riot-ci commented Oct 6, 2025 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

	#define CONFIG_EVENT_LOOP_DEBUG_THRESHOLD (0)
	#define CONFIG_EVENT_LOOP_DEBUG_THRESHOLD_US (0)

	#define CONFIG_EVENT_LOOP_DEBUG_THRESHOLD (0)
	# define CONFIG_EVENT_LOOP_DEBUG_THRESHOLD_US (0)

		uint32_t now2 = ztimer_now(ZTIMER_USEC);
		uint32_t dt = now2 - now;

	uint32_t now2 = ztimer_now(ZTIMER_USEC);
	uint32_t dt = now2 - now;
	uint32_t dt = ztimer_now(ZTIMER_USEC) - now;

	printf("eventh: %p took %" PRIu32 " µs\n",
	printf("event: %p took %" PRIu32 " µs\n",

- * @brief Threshold (USEC) below which event_handler are not printed,
- *        while debugging eventloop setting a value (!0) will also remove
- *        event_handler start message
+ * @brief Threshold in microseconds below which event_handler
+ *        are not printed.
+ *
+ * This can be used for debugging event loops. Setting a value
+ * other than zero will also remove the event_handler start message,

sys/event: add event loop debug threshold #21763

Are you sure you want to change the base?

sys/event: add event loop debug threshold #21763

Conversation

kfessel commented Oct 6, 2025

Contribution description

Testing procedure

Issues/PRs references

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kfessel Oct 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

riot-ci commented Oct 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Murdock results

Artifacts

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

kfessel Oct 6, 2025 •

edited

Loading

riot-ci commented Oct 6, 2025 •

edited

Loading