sys/net/nanocoap: improve coap_build_reply()
#21155
Open
+67
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maribu
added
Type: enhancement
github-actions
bot
added
Area: network
mguetschow
reviewed
Jan 23, 2025
maribu
force-pushed
the
sys/net/nanocoap/coap_build_reply
branch
3 times, most recently
from
e2464a0 to
58ca598
Compare
mguetschow
reviewed
Jan 23, 2025
mguetschow
reviewed
Jan 23, 2025
mguetschow
reviewed
Jan 23, 2025
Using a constant is easier than explaining where the magic 1 came from in size estimations.
maribu
force-pushed
the
sys/net/nanocoap/coap_build_reply
branch
2 times, most recently
from
7141f4f to
38397bc
Compare
mguetschow
reviewed
Jan 24, 2025
maribu
force-pushed
the
sys/net/nanocoap/coap_build_reply
branch
from
38397bc to
526310d
Compare
github-actions
bot
added
the
Area: CoAP
maribu
changed the title
coap_build_reply()coap_build_reply()
maribu
added
the
Process: API change
- The responsibility for handling matching CoAP No-Response Options
has been split:
- `coap_build_reply()` only needs to report this and return
`-ECANCLED`
- `coap_handle_req()` does generate the empty ACK is needed.
==> As a result, writing CoAP request handlers correctly becomes a
lost easier. Correct error handling to be present is now
sufficient for correct handling of No-Response options.
==> This change is backward compatible with existing code.
- The API doc has been cleaned up and straightened
Co-authored-by: mguetschow <mikolai.guetschow@tu-dresden.de>
maribu
force-pushed
the
sys/net/nanocoap/coap_build_reply
branch
from
526310d to
d1da109
Compare
|
I changed the API for handling with the No-Response case, so that less foot-shooting should occur. The API change is not breaking:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
coap_build_reply()only needs to report this and return-ECANCLEDcoap_handle_req()does generate the empty ACK is needed.==> As a result, writing CoAP request handlers correctly becomes a lost easier. Correct error handling to be present is now sufficient for correct handling of No-Response options.
==> This change is backward compatible with existing code.
Testing procedure
(CoAP reply handlers that did not get error handling correctly will stay broken.)
Issues/PRs references
None