sys/fido2: improve & simplify flash handling #21110
Open
+114
−152
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR tries to improve the flash handling done by the FIDO2 implementation. Specifically this entails:
mtd_aux
device to reserve flash memory for the FIDO2 data_flash_is_erased
function)mtd_flashpage
apiSince the AUX slot approach is integrated into the
mtd
API, which is the recommended method for working with flash, I wonder if theperiph_flashpage_in_address_space
feature I added to reserve flash memory for FIDO2 can now be deprecated ?@benpicco, with the
mtd_aux
approach, how can two different applications reserve flash memory without risking corruption of each other's data? Is it possible to divide the AUX slot into multiple smaller slots, that can be allocated for use by different applications?Testing procedure
/tests/sys/fido2_ctap
with bothnative
andnrf52840dk
as target/tests/sys/fido2_ctap_hid