Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gcoap: fix code quality defects #20518

Merged
merged 2 commits into from
Mar 28, 2024
Merged

gcoap: fix code quality defects #20518

merged 2 commits into from
Mar 28, 2024

Conversation

miri64
Copy link
Member

@miri64 miri64 commented Mar 28, 2024 •
edited
Loading

Contribution description

Of course I realize some quality defects in #20514 only after it was merged. This fixes that.

Testing procedure

Just formatting and documentation fixes. So compilation by the CI and looking at the built documentation should suffice.

Issues/PRs references

Follow-up on #20514

@miri64 miri64 added Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Mar 28, 2024
@github-actions github-actions bot added Area: network Area: Networking Area: sys Area: System labels Mar 28, 2024
@miri64 miri64 requested a review from Teufelchen1 March 28, 2024 08:28
@riot-ci
Copy link

riot-ci commented Mar 28, 2024

Murdock results

✔️ PASSED

c05474c gcoap: fix function indentation after change of static inline

Success Failures Total Runtime
10026 0 10027 10m:39s

Artifacts

mguetschow
mguetschow approved these changes Mar 28, 2024
View reviewed changes
Copy link
Contributor

@mguetschow mguetschow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from looking at the changes :)

@miri64 miri64 added this pull request to the merge queue Mar 28, 2024
@benpicco benpicco added the Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer label Mar 28, 2024
Merged via the queue into RIOT-OS:master with commit 819a4a1 Mar 28, 2024
29 checks passed
@miri64 miri64 deleted the gcoap/bug/quality-defects branch March 28, 2024 14:28
@MrKevinWeiss MrKevinWeiss added this to the Release 2024.04 milestone Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mguetschow mguetschow mguetschow approved these changes

@Teufelchen1 Teufelchen1 Awaiting requested review from Teufelchen1

Assignees
No one assigned
Labels
Area: network Area: Networking Area: sys Area: System CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation
Projects
None yet
Milestone
Release 2024.04
Development

Successfully merging this pull request may close these issues.
5 participants
@miri64 @riot-ci @mguetschow @benpicco @MrKevinWeiss