Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

boards/generic-cc2538-cc2592-dk: add board support #20226

Merged
merged 1 commit into from
Jan 5, 2024
Merged

boards/generic-cc2538-cc2592-dk: add board support #20226

merged 1 commit into from
Jan 5, 2024

Conversation

maribu
Copy link
Member

@maribu maribu commented Jan 4, 2024 •
edited
Loading

Contribution description

The CC2538-CC2592-DK is one of the few readily available and affordable boards featuring a legacy CC2538 MCU. This PR adds support for that board. This hopefully makes maintaining RIOT support for that legacy MCU more affordable :-)

Testing procedure

  • read the documentation
  • make flash should work
  • make debug should work
  • make term should work
  • the SAUL integration of all buttons and the four user LEDs should work. (The fifth LED is an always-on power LED.)

Issues/PRs references

None

Update: I found the schematics here: https://github.com/knowic/CC2538_CC2592_DK
This enabled exposing all four user LEDs.

@github-actions github-actions bot added Area: doc Area: Documentation Area: boards Area: Board ports labels Jan 4, 2024
@maribu maribu added Type: new feature The issue requests / The PR implemements a new feature for RIOT CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Area: boards Area: Board ports and removed Area: doc Area: Documentation Area: boards Area: Board ports labels Jan 4, 2024
@riot-ci
Copy link

riot-ci commented Jan 4, 2024 •
edited
Loading

Murdock results

✔️ PASSED

947d05e boards/generic-cc2538-cc2592-dk: add board support

Success Failures Total Runtime
8101 0 8101 11m:45s

Artifacts

@github-actions github-actions bot added Area: doc Area: Documentation Area: tests Area: tests and testing framework Area: Kconfig Area: Kconfig integration labels Jan 4, 2024
benpicco
benpicco reviewed Jan 4, 2024
View reviewed changes
Copy link
Contributor

@benpicco benpicco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doccheck has some complaints, but you can squash directly.

boards/generic-cc2538-cc2592-dk/include/periph_conf.h Outdated Show resolved Hide resolved
@maribu maribu force-pushed the boards/generic-cc2538-cc2592-dk branch 2 times, most recently from bc53c70 to 64775d3 Compare January 4, 2024 16:37
@maribu maribu enabled auto-merge January 4, 2024 16:43
@maribu maribu added this pull request to the merge queue Jan 4, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 4, 2024
@maribu
boards/generic-cc2538-cc2592-dk: add board support
947d05e 
The CC2538-CC2592-DK is one of the few readily available and
affordable boards featuring a legacy CC2538 MCU. This should make
maintaining RIOT support for that legacy MCU more affordable :-)
@maribu maribu force-pushed the boards/generic-cc2538-cc2592-dk branch from 64775d3 to 947d05e Compare January 4, 2024 23:01
@maribu maribu requested a review from miri64 as a code owner January 4, 2024 23:01
@github-actions github-actions bot added the Area: examples Area: Example Applications label Jan 4, 2024
@maribu maribu enabled auto-merge January 4, 2024 23:01
@maribu maribu added this pull request to the merge queue Jan 5, 2024
Merged via the queue into RIOT-OS:master with commit 866f2a0 Jan 5, 2024
25 checks passed
@maribu
Copy link
Member Author

maribu commented Jan 5, 2024

Thanks :-)

@maribu maribu deleted the boards/generic-cc2538-cc2592-dk branch January 5, 2024 07:44
@MrKevinWeiss MrKevinWeiss added this to the Release 2024.01 milestone Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benpicco benpicco benpicco approved these changes

@leandrolanzieri leandrolanzieri Awaiting requested review from leandrolanzieri leandrolanzieri is a code owner

@jia200x jia200x Awaiting requested review from jia200x jia200x is a code owner

@MrKevinWeiss MrKevinWeiss Awaiting requested review from MrKevinWeiss MrKevinWeiss is a code owner

@aabadie aabadie Awaiting requested review from aabadie aabadie is a code owner

@MichelRottleuthner MichelRottleuthner Awaiting requested review from MichelRottleuthner MichelRottleuthner is a code owner

@miri64 miri64 Awaiting requested review from miri64 miri64 is a code owner

Assignees
No one assigned
Labels
Area: boards Area: Board ports Area: doc Area: Documentation Area: examples Area: Example Applications Area: Kconfig Area: Kconfig integration Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: new feature The issue requests / The PR implemements a new feature for RIOT
Projects
None yet
Milestone
Release 2024.01
Development

Successfully merging this pull request may close these issues.
4 participants
@maribu @riot-ci @benpicco @MrKevinWeiss