-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
makefiles/tests/tests.inc.mk: use native term for tests #20215
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benpicco
requested review from
smlng,
leandrolanzieri,
aabadie,
MichelRottleuthner and
fjmolinas
as code owners
December 23, 2023 17:28
github-actions
bot
added
Platform: native
Platform: This PR/issue effects the native platform
Area: tests
Area: tests and testing framework
Area: build system
Area: Build system
Area: boards
Area: Board ports
labels
Dec 23, 2023
benpicco
added
the
CI: ready for build
If set, CI server will compile all applications for all available boards for the labeled PR
label
Dec 23, 2023
benpicco
force-pushed
the
tests/native-term
branch
from
December 23, 2023 18:09
a7cd270
to
1efff74
Compare
OlegHahm
reviewed
Dec 23, 2023
benpicco
force-pushed
the
tests/native-term
branch
from
December 23, 2023 19:27
1efff74
to
d8cc2ac
Compare
maribu
approved these changes
Jan 2, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Jan 2, 2024
Copying from #20213 (comment):
Not sure, all tests there are covered by this (I hope so) |
Sadly they are not :-(. See RIOT-OS/Release-Specs#296 for a workaround. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Area: boards
Area: Board ports
Area: build system
Area: Build system
Area: tests
Area: tests and testing framework
CI: ready for build
If set, CI server will compile all applications for all available boards for the labeled PR
Platform: native
Platform: This PR/issue effects the native platform
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
Always use the
native
terminal for the automatic tests when using thenative
board.Testing procedure
The affected tests should still succeed on
native
.tests/sys/log_color on native
non-
native
tests should still work.tests/sys/log_color on samr21-xpro
Issues/PRs references
alternative to #20213