-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gnrc/ipv6/nib: don't do multicast address resolution on 6LoWPAN #20046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benpicco
requested review from
miri64,
haukepetersen,
PeterKietzmann and
cgundogan
as code owners
November 3, 2023 17:24
benpicco
changed the title
gnrc/ipv6/nib: don't do multicast neighbor solicitation on 6LoWPAN
gnrc/ipv6/nib: don't do multicast address resolution on 6LoWPAN
Nov 3, 2023
benpicco
added
Type: bug
The issue reports a bug / The PR fixes a bug (including spelling errors)
CI: ready for build
If set, CI server will compile all applications for all available boards for the labeled PR
labels
Nov 3, 2023
miri64
requested changes
Nov 4, 2023
benpicco
force-pushed
the
6lo_multicast_ns
branch
from
November 4, 2023 17:34
525c0e8
to
1cd4a0d
Compare
miri64
approved these changes
Nov 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK
bors merge |
please rebase! |
benpicco
force-pushed
the
6lo_multicast_ns
branch
from
November 10, 2023 11:11
1cd4a0d
to
75f10a5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Area: network
Area: Networking
Area: sys
Area: System
CI: ready for build
If set, CI server will compile all applications for all available boards for the labeled PR
Type: bug
The issue reports a bug / The PR fixes a bug (including spelling errors)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
The border router would send multicast neighbor solicitations when resolving node addresses.
This is against the specification.
Check if the interface is 6lo before starting multicast address resolution.
Testing procedure
Issues/PRs references
#16988 (comment)