Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gnrc/ipv6/nib: don't do multicast address resolution on 6LoWPAN #20046

Merged
merged 1 commit into from
Nov 10, 2023

Conversation

benpicco
Copy link
Contributor

@benpicco benpicco commented Nov 3, 2023

Contribution description

The border router would send multicast neighbor solicitations when resolving node addresses.
This is against the specification.
Check if the interface is 6lo before starting multicast address resolution.

Testing procedure

Issues/PRs references

#16988 (comment)

@github-actions github-actions bot added Area: network Area: Networking Area: sys Area: System labels Nov 3, 2023
@benpicco benpicco changed the title gnrc/ipv6/nib: don't do multicast neighbor solicitation on 6LoWPAN gnrc/ipv6/nib: don't do multicast address resolution on 6LoWPAN Nov 3, 2023
@benpicco benpicco requested a review from fabian18 November 3, 2023 17:24
@benpicco benpicco added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Nov 3, 2023
@benpicco benpicco requested a review from kfessel November 3, 2023 17:34
@riot-ci
Copy link

riot-ci commented Nov 3, 2023

Murdock results

✔️ PASSED

75f10a5 gnrc/ipv6/nib: don't do multicast neighbor solicitation on 6LoWPAN

Success Failures Total Runtime
7953 0 7953 09m:24s

Artifacts

sys/net/gnrc/network_layer/ipv6/nib/nib.c Outdated Show resolved Hide resolved
sys/net/gnrc/network_layer/ipv6/nib/nib.c Outdated Show resolved Hide resolved
Copy link
Member

@miri64 miri64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@miri64
Copy link
Member

miri64 commented Nov 5, 2023

bors merge

@kaspar030
Copy link
Contributor

please rebase!

@benpicco benpicco enabled auto-merge November 10, 2023 10:18
@benpicco benpicco added this pull request to the merge queue Nov 10, 2023
Merged via the queue into RIOT-OS:master with commit d783aa8 Nov 10, 2023
24 checks passed
@benpicco benpicco deleted the 6lo_multicast_ns branch November 10, 2023 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: network Area: Networking Area: sys Area: System CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants