tests/pkg/minmea: fixing RMC timestamp #20018

jan-mo · 2023-10-26T08:42:46Z

The RMC timestamp calculation was creating issues. The timestamp will be related to the EPOCH and time zone. Test on native will fail if the time zone is not set correctly. (see #20005)

how to test

TZ=GMT-1 make test

and

TZ=GMT make test

and

TZ=<any> make test

timedatectl list-timezones provides you with a List of timzones

do not fail

kfessel · 2023-10-26T12:04:44Z

the test should test message decoding not timezone handling (we might want to have another test for that and fix the underling issue)

kfessel · 2023-10-26T12:38:58Z

tests/pkg/minmea/main.c

            timestamp = mktime(&tm);
+            /* timestamp is dependent on given EPOCH time */


Suggested change

timestamp = mktime(&tm);

/* timestamp is dependent on given EPOCH time */

timestamp = mktime(&tm);

/* minmea is providing a UTC date time (decoded from the GPS Message)

mktime() assumes local time, the timestamp might therefor depend on EPOCH and timezone*/

kwark we should just use timegm()

Suggested change

timestamp = mktime(&tm);

/* timestamp is dependent on given EPOCH time */

timestamp = timegm(&tm);

timegm might not be supported by all libc

or we fix native #20023

timegm is not supported by the MCUs. I just remove the timestamp generation and we are just checking the raw time values here. The only function that is not checked here is minmea_getdatetime().

The minmea_getdatetime() does just fill the struct tm, so there should be no problem if we exclude that. see

There is also the minmea_gettime() this also uses timegm() but I think we can only test that on native. see

tests/pkg/minmea/main.c

riot-ci · 2023-10-27T12:02:46Z

Murdock results

✔️ PASSED

0f27efb tests/pkg/minmea: fixing RMC timestamp

Success	Failures	Total	Runtime
17	0	17	01m:16s

Artifacts

Documentation preview

benpicco · 2023-10-27T12:04:29Z

bors merge

19932: tests/periph: Add test using the Peripheral Selftest Shield r=benpicco a=maribu ### Contribution description This adds a test that makes use of the peripheral selftesting shield. #### ToDo - [x] Add doc ### Testing procedure - grab an Arduino UNO compatible board that has the Arduino pin map feature - connect it to the testing shield - configure the testing shield - make sure the VCC selector matches the logic level of the board (3.3V and 5V are the only options) - enabled all the "loops" needed for testing on SW1 - it could be that the UART on D0, D1 is used for stdio. In that case, do *NOT* close the loop - flash and run the test application ### Issues/PRs references none 20018: tests/pkg/minmea: fixing RMC timestamp r=benpicco a=jan-mo The RMC timestamp calculation was creating issues. The timestamp will be related to the EPOCH and time zone. Test on native will fail if the time zone is not set correctly. (see #20005) # how to test ``` TZ=GMT-1 make test ``` and ``` TZ=GMT make test ``` and ``` TZ=<any> make test ``` `timedatectl list-timezones` provides you with a List of timzones do not fail 20022: pkg/lwip: add support for slipdev r=benpicco a=benpicco 20025: tests/drivers/at: fix device table overflow r=benpicco a=krzysztof-cabaj ### Contribution description This PR fix device table overflow in `tests/driver/at`, which could lead to device crash. ### Testing procedure PR was tested on two nucleo boards with 2 and 3 UARTs (nucleo-l476rg and nucleo-l496zg). Flash `tests/driver/at` with and without this PR. Output with this PR: ``` > main(): This is RIOT! (Version: 2022.07-devel-5083-g2b9e8-tests-drivers-at) AT command test app > init 5 9600 Wrong UART device number - should by in range 0-2. > ``` Output without this PR: ``` > main(): This is RIOT! (Version: 2022.07-devel-5083-g2b9e8) AT command test app > init 5 9600 8001afd *** RIOT kernel panic: FAILED ASSERTION. *** halted. Context before hardfault: r0: 0x0000000a r1: 0x00000000 . . . ``` ### Issues/PRs references None Co-authored-by: Marian Buschsieweke <marian.buschsieweke@posteo.net> Co-authored-by: Jan Mohr <jan.mohr@ml-pa.com> Co-authored-by: Benjamin Valentin <benjamin.valentin@ml-pa.com> Co-authored-by: krzysztof-cabaj <kcabaj@gmail.com>

bors · 2023-10-27T14:25:37Z

Build failed (retrying...):

Murdock

19932: tests/periph: Add test using the Peripheral Selftest Shield r=benpicco a=maribu ### Contribution description This adds a test that makes use of the peripheral selftesting shield. #### ToDo - [x] Add doc ### Testing procedure - grab an Arduino UNO compatible board that has the Arduino pin map feature - connect it to the testing shield - configure the testing shield - make sure the VCC selector matches the logic level of the board (3.3V and 5V are the only options) - enabled all the "loops" needed for testing on SW1 - it could be that the UART on D0, D1 is used for stdio. In that case, do *NOT* close the loop - flash and run the test application ### Issues/PRs references none 20018: tests/pkg/minmea: fixing RMC timestamp r=benpicco a=jan-mo The RMC timestamp calculation was creating issues. The timestamp will be related to the EPOCH and time zone. Test on native will fail if the time zone is not set correctly. (see #20005) # how to test ``` TZ=GMT-1 make test ``` and ``` TZ=GMT make test ``` and ``` TZ=<any> make test ``` `timedatectl list-timezones` provides you with a List of timzones do not fail Co-authored-by: Marian Buschsieweke <marian.buschsieweke@posteo.net> Co-authored-by: Jan Mohr <jan.mohr@ml-pa.com>

bors · 2023-10-27T14:27:04Z

This PR was included in a batch that was canceled, it will be automatically retried

bors · 2023-10-27T14:49:45Z

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

jan-mo requested review from smlng, leandrolanzieri, aabadie, MichelRottleuthner and fjmolinas as code owners October 26, 2023 08:42

github-actions bot added the Area: tests Area: tests and testing framework label Oct 26, 2023

kfessel reviewed Oct 26, 2023

View reviewed changes

benpicco reviewed Oct 26, 2023

View reviewed changes

tests/pkg/minmea/main.c Outdated Show resolved Hide resolved

kfessel mentioned this pull request Oct 26, 2023

board/native: set TZ to UTC by default #20023

Open

tests/pkg/minmea: fixing RMC timestamp

0f27efb

jan-mo force-pushed the fix/20231026__NMEA_RMC_date_time branch from d6c18cb to 0f27efb Compare October 27, 2023 07:44

benpicco added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Oct 27, 2023

benpicco approved these changes Oct 27, 2023

View reviewed changes

bors bot merged commit 47f0446 into RIOT-OS:master Oct 27, 2023
27 checks passed

MrKevinWeiss added this to the Release 2024.01 milestone Feb 7, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

tests/pkg/minmea: fixing RMC timestamp #20018

tests/pkg/minmea: fixing RMC timestamp #20018

jan-mo commented Oct 26, 2023 •

edited by kfessel

Loading

kfessel commented Oct 26, 2023

kfessel Oct 26, 2023

kfessel Oct 26, 2023

kfessel Oct 26, 2023

kfessel Oct 26, 2023

jan-mo Oct 27, 2023

jan-mo Oct 27, 2023

riot-ci commented Oct 27, 2023

benpicco commented Oct 27, 2023

bors bot commented Oct 27, 2023

bors bot commented Oct 27, 2023

bors bot commented Oct 27, 2023

		timestamp = mktime(&tm);
		/* timestamp is dependent on given EPOCH time */

	timestamp = mktime(&tm);
	/* timestamp is dependent on given EPOCH time */
	timestamp = timegm(&tm);

tests/pkg/minmea: fixing RMC timestamp #20018

tests/pkg/minmea: fixing RMC timestamp #20018

Conversation

jan-mo commented Oct 26, 2023 • edited by kfessel Loading

how to test

kfessel commented Oct 26, 2023

kfessel Oct 26, 2023

Choose a reason for hiding this comment

kfessel Oct 26, 2023

Choose a reason for hiding this comment

kfessel Oct 26, 2023

Choose a reason for hiding this comment

kfessel Oct 26, 2023

Choose a reason for hiding this comment

jan-mo Oct 27, 2023

Choose a reason for hiding this comment

jan-mo Oct 27, 2023

Choose a reason for hiding this comment

riot-ci commented Oct 27, 2023

Murdock results

Artifacts

benpicco commented Oct 27, 2023

bors bot commented Oct 27, 2023

bors bot commented Oct 27, 2023

bors bot commented Oct 27, 2023

jan-mo commented Oct 26, 2023 •

edited by kfessel

Loading