-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tools/hydracomment: Add tool for simultaneous commenting #20001
Open
bergzand
wants to merge
1
commit into
RIOT-OS:master
Choose a base branch
from
bergzand:pr/dist/hydracomment
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bergzand
added
Type: new feature
The issue requests / The PR implemements a new feature for RIOT
Area: tools
Area: Supplementary tools
labels
Oct 19, 2023
hello world! |
bergzand
force-pushed
the
pr/dist/hydracomment
branch
from
October 19, 2023 21:29
d9d1e87
to
0fcde52
Compare
bergzand
force-pushed
the
pr/dist/hydracomment
branch
from
October 19, 2023 21:30
0fcde52
to
68db62d
Compare
bergzand
added
the
CI: skip compile test
If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs
label
Oct 19, 2023
maribu
reviewed
Oct 20, 2023
parser.add_argument( | ||
"-c", | ||
"--comment", | ||
default="Bors merge", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
default="Bors merge", | |
default="bors merge", |
I'm not sure if it is case sensitive, but so far we always used the lower case version.
Why not just use github-cli in a loop? |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Area: doc
Area: Documentation
Area: tools
Area: Supplementary tools
CI: skip compile test
If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs
Type: new feature
The issue requests / The PR implemements a new feature for RIOT
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
This is a very low effort python tool to place an identical comment under multiple PRs simultaneously.
I have put very little effort into this, mostly written by scavenging bits and pieces from the
backport_pr
tool, and it hasn't been thoroughly tested so far. Feel free to push fixups and cleanups to this branch 😉Main use case is to make it easy to set up merge trains by putting a 'bors merge' under multiple PRs at the same time
Testing procedure
With great power comes great responsibility.
Issues/PRs references
None