makefiles/arch/riscv.inc.mk: speed up toolchain detection #19791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Area: build system
maribu
force-pushed
the
makefiles/arch/riscv.inc.mk-speed-up
branch
from
3cbeb25 to
4b2d25b
Compare
maribu
added
Type: bug
maribu
commented
Jul 3, 2023
- Use a sane (a.k.a. simply expanded) variable for the `$(TARGET_ARCH)`
instead of an insane (a.k.a. recursive expended) variable
- The toolchain detection will now happen only once, rather than
each and every time `$(TARGET_ARCH)` is referenced
- Use a single call to `which` rather than one per possible target
triple
Fixes RIOT-OS#19788
maribu
force-pushed
the
makefiles/arch/riscv.inc.mk-speed-up
branch
from
f1a0389 to
55e2233
Compare
benpicco
approved these changes
Jul 6, 2023
|
bors merge |
|
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
$(TARGET_ARCH)instead of an insane (a.k.a. recursive expended) variable - The toolchain detection will now happen only once, rather than each and every time$(TARGET_ARCH)is referencedwhichrather than one per possible target tripleFixes #19788
Testing procedure
should no be faster than in
masterIssues/PRs references
Fixes #19788