Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drivers/mq3: avoid use of floats #19696

Merged
merged 1 commit into from
Jun 2, 2023
Merged

drivers/mq3: avoid use of floats #19696

merged 1 commit into from
Jun 2, 2023

Conversation

maribu
Copy link
Member

@maribu maribu commented May 31, 2023

Contribution description

As the title says.

Testing procedure

Code review should be sufficient.

Issues/PRs references

#19614

@maribu maribu added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation Area: drivers Area: Device drivers CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels May 31, 2023
@maribu maribu mentioned this pull request May 31, 2023
Open
19 tasks
kfessel
kfessel reviewed May 31, 2023
View reviewed changes
drivers/mq3/mq3.c Outdated Show resolved Hide resolved
@riot-ci
Copy link

riot-ci commented May 31, 2023 •
edited
Loading

Murdock results

✔️ PASSED

e29499c drivers/mq3: avoid use of floats

Success Failures Total Runtime
6933 0 6933 21m:26s

Artifacts

kfessel
kfessel reviewed Jun 1, 2023
View reviewed changes
drivers/mq3/mq3.c Outdated Show resolved Hide resolved
@maribu
Copy link
Member Author

maribu commented Jun 2, 2023

bors merge

@bors
Copy link
Contributor

bors bot commented Jun 2, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit d16f8f1 into RIOT-OS:master Jun 2, 2023
@benpicco benpicco added this to the Release 2023.07 milestone Aug 2, 2023
@maribu maribu deleted the drivers/mq3 branch December 5, 2023 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kfessel kfessel kfessel left review comments

@benpicco benpicco benpicco approved these changes

Assignees
No one assigned
Labels
Area: drivers Area: Device drivers CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation
Projects
None yet
Milestone
Release 2023.07
Development

Successfully merging this pull request may close these issues.
4 participants
@maribu @riot-ci @kfessel @benpicco