core: put more intelligence into queue_msg()
#1961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #1942. There were two instances were it was not checked the target thread has a message queue before queuing the message. This PR centralizes the check into `queue_msg()`.
Kijewski
added
Area: core
|
Tagging as [major], because |
|
You mention two instances, but fix one? Still ACK. |
|
This PR fixes |
|
So |
|
Anyway small progress is better than no progress: ACK |
|
|
| return 0; | ||
| DEBUG("queue_msg(): queuing message\n"); | ||
| msg_t *dest = &target->msg_array[n]; | ||
| *dest = *m; |
There was a problem hiding this comment.
Why the double assignment here?
Pointers sometimes still confuse me -.-
|
I revoke my NACK… merge at will. |
Yes, it is. |
Kijewski
added a commit
that referenced
this pull request
Nov 7, 2014
core: put more intelligence into `queue_msg()`
|
I think the check was already in place by checking the return value of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1942.
There were two instances were it was not checked the target thread has a
message queue before queuing the message.
This PR centralizes the check into
queue_msg().(This PR is part of #1939)