tests/periph_adc: added test for adc driver #1951
Conversation
|
Tested with stm32f4discovery. Worked fine! stm32f0discovery does not provide |
| /* convert each channel for this ADC device */ | ||
| for (int i = 0; i < ADC_NUMOF; i++) { | ||
| for (int j = 0; j < ADC_1_CHANNELS; j++) { | ||
| values[i][j] = adc_sample(i, j); |
There was a problem hiding this comment.
Shouldn't this be ADC_MAX_CHANNELS ?
There was a problem hiding this comment.
yes, youre right. Copy and paste failure...
|
Ok Travis was happy, hm.. For some reason the loop just iterates once on the stm32f0discovery board, after changing the above comments. Also LED |
haukepetersen
force-pushed
the
add_test_periphadc
branch
from
19481e9 to
1a9e19c
Compare
|
fixed channel define as pointed out by @PeterKietzmann |
|
@PeterKietzmann the problem with the stm32f0 looks like it has to do something with the vtimer, could be connected to #1519 |
|
and for the missing ADC feature please see (and review) #1955 |
|
@PeterKietzmann I also found the problem with the vtimer that made the ADC test fail, see #1956 |
|
#1956 fixed the problems on stm32f0discovery |
|
so can we merge this test? |
|
Si senor, the test is fine. ACK |
|
and go. |
tests/periph_adc: added test for adc driver
No description provided.