sys/shell: added commands for iot-lab_M3 sensors #1949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haukepetersen
added
Newbie-Task-Candidate
Type: new feature
haukepetersen
force-pushed
the
add_shell_sensorcommands
branch
from
823cba8 to
141ece6
Compare
|
reduced scope of variables as pointed out by cppcheck. |
|
|
||
| int val; | ||
|
|
||
| if (!isl29020_dev.i2c) { |
There was a problem hiding this comment.
Apparently this check is always true.
There was a problem hiding this comment.
true, now I wonder why it worked yesterday...
haukepetersen
force-pushed
the
add_shell_sensorcommands
branch
from
141ece6 to
b59e193
Compare
|
Addressed comment by @OlegHahm (seems you were not the only one tired yesterday night :-) ) |
haukepetersen
force-pushed
the
add_shell_sensorcommands
branch
from
b59e193 to
7e043bb
Compare
|
rebased after #1947 was merged. |
|
I'm happy (ACKy) when Travis is. |
|
Go |
thomaseichinger
added a commit
that referenced
this pull request
Nov 6, 2014
sys/shell: added commands for iot-lab_M3 sensors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rebased on #1947