tests/gnrc_rpl: speed up test #19134

benpicco · 2023-01-12T14:59:06Z

Contribution description

Add a printout when the global prefix has been received that we can await.
Strangely we still have to wait 5s after that for ping to work.

Testing procedure

make -C tests/gnrc_rpl all test

should still work.

Without 5s sleep, routing is broken

 -=[ A ]=-
ifconfig
Iface  5  HWaddr: 5E:76  Channel: 26  NID: 0x23  PHY: O-QPSK 
          Long HWaddr: E6:B2:35:37:6F:CC:DE:76 
           State: IDLE 
          ACK_REQ  L2-PDU:102  MTU:1280  HL:64  RTR  
          6LO  IPHC  
          Source address length: 8
          Link type: wireless
          inet6 addr: fe80::e4b2:3537:6fcc:de76  scope: link  VAL
          inet6 addr: 2001:db8::1  scope: global  VAL
          inet6 group: ff02::2
          inet6 group: ff02::1
          inet6 group: ff02::1:ffcc:de76
          inet6 group: ff02::1a
          inet6 group: ff02::1:ff00:1
          

rpl
instance table:	[X]	
parent table:	[ ]	[ ]	[ ]	

instance [0 | Iface: 5 | mop: 2 | ocp: 0 | mhri: 256 | mri 0]
	dodag [2001:db8::1 | R: 256 | OP: Router | PIO: on | TR(I=[8,20], k=10, c=1)]

nib route
2001:db8::/32 dev #5

 -=[ B ]=-
ifconfig
Iface  5  HWaddr: 6E:86  Channel: 26  NID: 0x23  PHY: O-QPSK 
          Long HWaddr: 7E:D6:55:9B:BF:1C:6E:86 
           State: IDLE 
          ACK_REQ  L2-PDU:102  MTU:1280  HL:64  RTR  
          6LO  IPHC  
          Source address length: 8
          Link type: wireless
          inet6 addr: fe80::7cd6:559b:bf1c:6e86  scope: link  VAL
          inet6 addr: 2001:db8::7cd6:559b:bf1c:6e86  scope: global  VAL
          inet6 group: ff02::2
          inet6 group: ff02::1
          inet6 group: ff02::1:ff1c:6e86
          inet6 group: ff02::1a
          

rpl
instance table:	[X]	
parent table:	[X]	[ ]	[ ]	

instance [0 | Iface: 5 | mop: 2 | ocp: 0 | mhri: 256 | mri 0]
	dodag [2001:db8::1 | R: 512 | OP: Router | PIO: on | TR(I=[8,20], k=10, c=2)]
		parent [addr: fe80::e4b2:3537:6fcc:de76 | rank: 256]

nib route
2001:db8::/64 dev #5
default* via fe80::e4b2:3537:6fcc:de76 dev #5

 -=[ C ]=-
ifconfig
Iface  5  HWaddr: 5E:F6  Channel: 26  NID: 0x23  PHY: O-QPSK 
          Long HWaddr: E6:62:B5:07:EF:4C:5E:F6 
           State: IDLE 
          ACK_REQ  L2-PDU:102  MTU:1280  HL:64  RTR  
          6LO  IPHC  
          Source address length: 8
          Link type: wireless
          inet6 addr: fe80::e462:b507:ef4c:5ef6  scope: link  VAL
          inet6 addr: 2001:db8::e462:b507:ef4c:5ef6  scope: global  VAL
          inet6 group: ff02::2
          inet6 group: ff02::1
          inet6 group: ff02::1:ff4c:5ef6
          inet6 group: ff02::1a
          

rpl
instance table:	[X]	
parent table:	[X]	[ ]	[ ]	

instance [0 | Iface: 5 | mop: 2 | ocp: 0 | mhri: 256 | mri 0]
	dodag [2001:db8::1 | R: 768 | OP: Router | PIO: on | TR(I=[8,20], k=10, c=2)]
		parent [addr: fe80::7cd6:559b:bf1c:6e86 | rank: 512]

nib route
2001:db8::/64 dev #5
default* via fe80::7cd6:559b:bf1c:6e86 dev #5

 -=[ D ]=-
ifconfig
Iface  5  HWaddr: 73:C1  Channel: 26  NID: 0x23  PHY: O-QPSK 
          Long HWaddr: 7E:56:B4:97:DA:1F:F3:C1 
           State: IDLE 
          ACK_REQ  L2-PDU:102  MTU:1280  HL:64  RTR  
          6LO  IPHC  
          Source address length: 8
          Link type: wireless
          inet6 addr: fe80::7c56:b497:da1f:f3c1  scope: link  VAL
          inet6 addr: 2001:db8::7c56:b497:da1f:f3c1  scope: global  VAL
          inet6 group: ff02::2
          inet6 group: ff02::1
          inet6 group: ff02::1:ff1f:f3c1
          inet6 group: ff02::1a
          

rpl
instance table:	[X]	
parent table:	[X]	[ ]	[ ]	

instance [0 | Iface: 5 | mop: 2 | ocp: 0 | mhri: 256 | mri 0]
	dodag [2001:db8::1 | R: 1024 | OP: Router | PIO: on | TR(I=[8,20], k=10, c=0)]
		parent [addr: fe80::e462:b507:ef4c:5ef6 | rank: 768]

nib route
2001:db8::/64 dev #5
default* via fe80::e462:b507:ef4c:5ef6 dev #5

ping 2001:db8::1

--- 2001:db8::1 PING statistics ---
3 packets transmitted, 0 packets received, 100% packet loss

Issues/PRs references

riot-ci · 2023-01-12T15:00:34Z

Murdock results

✔️ PASSED

cfac5e5 tests/gnrc_rpl: speed up test

Success	Failures	Total	Runtime
43	0	43	01m:44s

Artifacts

Documentation preview

Add a printout when the global prefix has been received that we can await. Strangely we still have to wait 5s after that for ping to work.

benpicco · 2023-01-12T15:12:51Z

bors try

miri64 · 2023-01-12T15:42:17Z

Strangely we still have to wait 5s after that for ping to work.

Did you check if the DODAG was actually constructed at that point (i.e. if the pinging nodes have a parent)?

miri64 · 2023-01-12T15:42:59Z

tests/gnrc_rpl/tests/01-run.py

-    A.cmd("nib prefix add 5 2001:db8::/32")
-    A.cmd("ifconfig 5 add 2001:db8::1/32")
+    A.cmd("nib prefix add 5 2001:db8::/64")
+    A.cmd("ifconfig 5 add 2001:db8::1/64")


Why is this change needed?

It's not needed, but a /64 is also enough and more idiomatic

miri64 · 2023-01-12T15:43:05Z

tests/gnrc_rpl/tests/01-run.py

-    A.cmd("nib prefix add 5 2001:db8::/32")
-    A.cmd("ifconfig 5 add 2001:db8::1/32")
+    A.cmd("nib prefix add 5 2001:db8::/64")
+    A.cmd("ifconfig 5 add 2001:db8::1/64")


benpicco · 2023-01-12T15:49:00Z

Did you check if the DODAG was actually constructed at that point

yes, click the "Without 5s sleep, routing is broken" to expand the results

miri64 · 2023-01-12T15:54:38Z

Is it exactly 5s or did you pick that value arbitrarily?

benpicco · 2023-01-12T15:57:39Z

4s also works, 3s is too little

miri64 · 2023-01-12T16:18:15Z

Ok, I thought it might have to do something with address registration, but then again, the global address is valid already. Should we document this in an issue?

bors · 2023-01-12T17:55:21Z

try

Build succeeded:

benpicco · 2023-01-14T22:37:15Z

I created an issue: #19147

kaspar030 · 2023-01-17T08:03:48Z

make test gives this error, similar to the flakey CI failures:

Traceback (most recent call last):
  File "/home/kaspar/src/riot/tests/gnrc_rpl/tests/01-run.py", line 178, in <module>
    run_test(test_alternative_route, factory)
  File "/home/kaspar/src/riot/tests/gnrc_rpl/tests/01-run.py", line 170, in run_test
    func(factory, zep_dispatch)
  File "/home/kaspar/src/riot/tests/gnrc_rpl/tests/01-run.py", line 155, in test_alternative_route
    assert result['stats']['packet_loss'] < 10
AssertionError

But this PR is not intended to fix that, right?

benpicco · 2023-01-17T08:06:27Z

I had hoped by actually waiting for the global address the test would be more stable, but that didn’t turn out to be the case 😔

kaspar030 · 2023-01-17T08:13:16Z

hm, my first run failed, now I'm at ~15, all runs after the first succeeded

miri64 · 2023-01-17T11:24:34Z

Maybe something akin to https://pypi.org/project/pytest-rerunfailures/ to our tests would help here (or we port the test to pytest directly and just use that plug-in ;-P). With the TEST_EXECUTOR environment variable, this should be a breeze to port.

benpicco requested a review from miri64 as a code owner January 12, 2023 14:59

benpicco added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Jan 12, 2023

github-actions bot added the Area: tests Area: tests and testing framework label Jan 12, 2023

benpicco requested a review from bergzand January 12, 2023 15:01

tests/gnrc_rpl: speed up test

cfac5e5

Add a printout when the global prefix has been received that we can await. Strangely we still have to wait 5s after that for ping to work.

benpicco force-pushed the tests/gnrc_rpl-speedup branch from 57e131b to cfac5e5 Compare January 12, 2023 15:02

benpicco added the Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation label Jan 12, 2023

bors bot added a commit that referenced this pull request Jan 12, 2023

Try #19134:

c7699a4

miri64 reviewed Jan 12, 2023

View reviewed changes

benpicco mentioned this pull request Jan 14, 2023

gnrc_rpl: takes unusually long time to start routing packets #19147

Open

benpicco requested a review from kaspar030 January 16, 2023 10:37

benpicco requested a review from maribu January 19, 2023 12:32

benpicco added the State: waiting for maintainer State: Action by a maintainer is required label Feb 2, 2023

benpicco requested a review from fabian18 February 10, 2023 15:18

benpicco requested a review from kfessel February 28, 2023 18:01

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

tests/gnrc_rpl: speed up test #19134

tests/gnrc_rpl: speed up test #19134

benpicco commented Jan 12, 2023 •

edited

Loading

riot-ci commented Jan 12, 2023 •

edited

Loading

benpicco commented Jan 12, 2023

miri64 commented Jan 12, 2023

miri64 Jan 12, 2023

benpicco Jan 12, 2023 •

edited

Loading

miri64 Jan 12, 2023

benpicco commented Jan 12, 2023

miri64 commented Jan 12, 2023

benpicco commented Jan 12, 2023

miri64 commented Jan 12, 2023

bors bot commented Jan 12, 2023

benpicco commented Jan 14, 2023

kaspar030 commented Jan 17, 2023

benpicco commented Jan 17, 2023

kaspar030 commented Jan 17, 2023

miri64 commented Jan 17, 2023

tests/gnrc_rpl: speed up test #19134

Are you sure you want to change the base?

tests/gnrc_rpl: speed up test #19134

Conversation

benpicco commented Jan 12, 2023 • edited Loading

Contribution description

Testing procedure

Issues/PRs references

riot-ci commented Jan 12, 2023 • edited Loading

Murdock results

Artifacts

benpicco commented Jan 12, 2023

miri64 commented Jan 12, 2023

miri64 Jan 12, 2023

Choose a reason for hiding this comment

benpicco Jan 12, 2023 • edited Loading

Choose a reason for hiding this comment

miri64 Jan 12, 2023

Choose a reason for hiding this comment

benpicco commented Jan 12, 2023

miri64 commented Jan 12, 2023

benpicco commented Jan 12, 2023

miri64 commented Jan 12, 2023

bors bot commented Jan 12, 2023

try

benpicco commented Jan 14, 2023

kaspar030 commented Jan 17, 2023

benpicco commented Jan 17, 2023

kaspar030 commented Jan 17, 2023

miri64 commented Jan 17, 2023

benpicco commented Jan 12, 2023 •

edited

Loading

riot-ci commented Jan 12, 2023 •

edited

Loading

benpicco Jan 12, 2023 •

edited

Loading