Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.vscode: import initial RIOT-OS style #18945

Merged
merged 2 commits into from
Nov 22, 2022

Conversation

dylad
Copy link
Member

@dylad dylad commented Nov 21, 2022

Contribution description

This PR adds initial RIOT-OS style for Vscode like editor.
By default, vscode tries to auto-detect the file settings but it can easily be biaised. Thus, let's fix it by creating a few rules.

Testing procedure

Open RIOT-OS folder inside vscode or vscodium, open any .c, .h or Makefiles files and check if defaults settings are correct.

Issues/PRs references

Trying to fix @maribu frustration here :)

Signed-off-by: Dylan Laduranty <dylan.laduranty@mesotic.com>
Signed-off-by: Dylan Laduranty <dylan.laduranty@mesotic.com>
@dylad dylad requested a review from maribu November 21, 2022 20:43
Copy link
Member

@maribu maribu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK. Thanks! That will be quite helpful :)

@maribu maribu added Type: new feature The issue requests / The PR implemements a new feature for RIOT CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Area: tools Area: Supplementary tools labels Nov 21, 2022
@dylad dylad added the CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs label Nov 21, 2022
@riot-ci
Copy link

riot-ci commented Nov 22, 2022

Murdock results

✔️ PASSED

d998854 .vscode/settings.json: import initial RIOT-OS style

Success Failures Total Runtime
1 0 1 57s

Artifacts

@maribu maribu merged commit 54b0100 into RIOT-OS:master Nov 22, 2022
@dylad dylad deleted the pr/vscode_import_riot_styles branch November 30, 2022 15:16
@kaspar030 kaspar030 added this to the Release 2023.01 milestone Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: tools Area: Supplementary tools CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs Type: new feature The issue requests / The PR implemements a new feature for RIOT
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants