rust: Don't be so picky about toolchains #18840
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrysn
added
Area: build system
github-actions
bot
added
Area: doc
This is possible starting with Rust 1.65.
chrysn
force-pushed
the
rust-use-stable-2
branch
from
38df572
to
e3d8127
Compare
4 tasks
bors bot
added a commit
that referenced
this pull request
Jan 12, 2023
19058: rust: Use stable Rust [backport 2022.10] r=maribu a=maribu # Backport of #18839 ### Contribution description Since Rust 1.65, we don't depend on anything nightly any more. This changes the examples and documentation to use stable. ### Testing procedure * Green CI with tests enabled * Look at changed documentation ([rendered](https://ci.riot-os.org/results/2923b30a4ba04dbface1ed38fb6aae12/doc-preview/using-rust.html#toolchain)) <del>Note that these will *not* pass yet: This needs a CI update (no PR associated: Any CI image built from now on will do).</del> ### Issues/PRs references A follow-up will simplify things a bit further, but that will depend on CI to have made stable the default, which is a later step in what is a bit of a lock-step game: * [x] CI rebuilds riotdocker -- no PR, then stable=1.65 * [ ] Use stable in examples -- this PR, then examples use stable * [ ] CI removes nightly and makes stable the default -- RIOT-OS/riotdocker#214, then default=stable * [ ] Use the new default to simplify makefiles -- #18840 Co-authored-by: chrysn <chrysn@fsfe.org>
bors bot
added a commit
that referenced
this pull request
Jan 12, 2023
19058: rust: Use stable Rust [backport 2022.10] r=maribu a=maribu # Backport of #18839 ### Contribution description Since Rust 1.65, we don't depend on anything nightly any more. This changes the examples and documentation to use stable. ### Testing procedure * Green CI with tests enabled * Look at changed documentation ([rendered](https://ci.riot-os.org/results/2923b30a4ba04dbface1ed38fb6aae12/doc-preview/using-rust.html#toolchain)) <del>Note that these will *not* pass yet: This needs a CI update (no PR associated: Any CI image built from now on will do).</del> ### Issues/PRs references A follow-up will simplify things a bit further, but that will depend on CI to have made stable the default, which is a later step in what is a bit of a lock-step game: * [x] CI rebuilds riotdocker -- no PR, then stable=1.65 * [ ] Use stable in examples -- this PR, then examples use stable * [ ] CI removes nightly and makes stable the default -- RIOT-OS/riotdocker#214, then default=stable * [ ] Use the new default to simplify makefiles -- #18840 Co-authored-by: chrysn <chrysn@fsfe.org>
bors bot
added a commit
that referenced
this pull request
Jan 12, 2023
19058: rust: Use stable Rust [backport 2022.10] r=miri64 a=maribu # Backport of #18839 ### Contribution description Since Rust 1.65, we don't depend on anything nightly any more. This changes the examples and documentation to use stable. ### Testing procedure * Green CI with tests enabled * Look at changed documentation ([rendered](https://ci.riot-os.org/results/2923b30a4ba04dbface1ed38fb6aae12/doc-preview/using-rust.html#toolchain)) <del>Note that these will *not* pass yet: This needs a CI update (no PR associated: Any CI image built from now on will do).</del> ### Issues/PRs references A follow-up will simplify things a bit further, but that will depend on CI to have made stable the default, which is a later step in what is a bit of a lock-step game: * [x] CI rebuilds riotdocker -- no PR, then stable=1.65 * [ ] Use stable in examples -- this PR, then examples use stable * [ ] CI removes nightly and makes stable the default -- RIOT-OS/riotdocker#214, then default=stable * [ ] Use the new default to simplify makefiles -- #18840 Co-authored-by: chrysn <chrysn@fsfe.org>
bors bot
added a commit
that referenced
this pull request
Jan 12, 2023
19058: rust: Use stable Rust [backport 2022.10] r=miri64 a=maribu # Backport of #18839 ### Contribution description Since Rust 1.65, we don't depend on anything nightly any more. This changes the examples and documentation to use stable. ### Testing procedure * Green CI with tests enabled * Look at changed documentation ([rendered](https://ci.riot-os.org/results/2923b30a4ba04dbface1ed38fb6aae12/doc-preview/using-rust.html#toolchain)) <del>Note that these will *not* pass yet: This needs a CI update (no PR associated: Any CI image built from now on will do).</del> ### Issues/PRs references A follow-up will simplify things a bit further, but that will depend on CI to have made stable the default, which is a later step in what is a bit of a lock-step game: * [x] CI rebuilds riotdocker -- no PR, then stable=1.65 * [ ] Use stable in examples -- this PR, then examples use stable * [ ] CI removes nightly and makes stable the default -- RIOT-OS/riotdocker#214, then default=stable * [ ] Use the new default to simplify makefiles -- #18840 Co-authored-by: chrysn <chrysn@fsfe.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
So far, we've forced the Rust version to be used quite a bit. Now that we'll only have stable Rust in docker anyway and won't have breaking changes from Rust any more, we can relax this a bit.
The current changes in this PR simplify the documented installation steps and relax the choice of which Rust toolchain is used for building examples.
Open questions
Do we want to go even further, remove all the
CARGO_CHANNELinfrastructure and rely purely on Rust mechanisms (rustup toolchain default/rustup toolchain override/rust-toolchain.toml/RUSTUP_TOOLCHAIN=) for selecting the toolchani?I'm leaning towards "yes"; we can do that now, so why insist on own stuff when we don't need to any more.
Testing procedure
Issues/PRs references
This builds on #18839 -- see there for an overview list of locksteps with CI.