nanocoap_sock: consitfy remote #18588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benpicco
requested review from
miri64,
haukepetersen,
PeterKietzmann and
cgundogan
as code owners
github-actions
bot
added
Area: CoAP
benpicco
force-pushed
the
nanocoap_const_remote
branch
from
6e55aa0 to
587afab
Compare
benpicco
added
Type: cleanup
benpicco
commented
Sep 13, 2022
| int nanocoap_sock_connect(nanocoap_sock_t *sock, sock_udp_ep_t *local, sock_udp_ep_t *remote) | ||
| { | ||
| if (!remote->port) { | ||
| remote->port = COAP_PORT; |
There was a problem hiding this comment.
Technically this makes this an API change, but I couldn't find a user other than nanocoap_sock_url_connect() that relied on this.
maribu
approved these changes
Sep 13, 2022
|
There is one more. diff --git a/sys/include/net/nanocoap_sock.h b/sys/include/net/nanocoap_sock.h
index e9b2f48fd8..077dde7170 100644
--- a/sys/include/net/nanocoap_sock.h
+++ b/sys/include/net/nanocoap_sock.h
@@ -396,7 +396,7 @@ ssize_t nanocoap_get(const sock_udp_ep_t *remote, const char *path,
* @retval <0 Error (see @ref nanocoap_sock_connect for details)
*/
static inline int nanocoap_block_request_init(coap_block_request_t *ctx,
- sock_udp_ep_t *remote,
+ const sock_udp_ep_t *remote,
const char *path,
uint8_t method,
coap_blksize_t blksize) |
benpicco
force-pushed
the
nanocoap_const_remote
branch
from
587afab to
b6fac2b
Compare
|
Good catch! |
benpicco
added
the
Process: API change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
The
remoteargument is passed to a function that accepts aconstpointer.Since we might want to store
remotein flash or use the one returned bycoap_request_ctx_get_remote_udp(), also make theremoteargumentconstin nanoCoAP sock.Testing procedure
Green CI
Issues/PRs references