Add Bangle.JS2 smart watch board support #18554

nica-f · 2022-09-04T23:06:57Z

boards: bangle-js2, remove no more needed module

boards: bangle/js2, remove sector count, will get auto detected

boards: bangle-js2, reformat comments for coding style

boards: bangle-js2, remove unnecessary definition of openocd

boards: Add Bangle-JS2 smart watch board support

Adds board support for the Bangle-JS2 smart watch.

Running on my watch for several days :-)

Resolves #18553

boards: bangle-js2, remove no more needed module boards: bangle/js2, remove sector count, will get auto detected boards: bangle-js2, reformat comments for coding style boards: bangle-js2, remove unnecessary definition of openocd

benpicco

static tests have some complains and // C++ comments should be converted to /* C-style comments */

benpicco · 2022-09-04T23:33:30Z

boards/banglejs-2/Makefile.dep

+  USEMODULE += mtd_spi_nor
+endif
+
+USEMODULE += cst816s


Suggested change

USEMODULE += cst816s

ifneq (,$(filter touch_dev,$(USEMODULE)))

USEMODULE += cst816s

endif

benpicco · 2022-09-04T23:34:26Z

boards/banglejs-2/board.c

+
+void board_power_off(void)
+{
+    ztimer_sleep(ZTIMER_MSEC, 5);


Nothing happens before the sleep - what is is good for?

benpicco · 2022-09-04T23:38:04Z

boards/banglejs-2/board.c

+};
+
+mtd_dev_t *mtd0 = (mtd_dev_t *)&banglejs2_nor_dev;
+#endif /* MODULE_MTD */


If you want to have a file system on the external flash you could add

#ifdef MODULE_VFS_DEFAULT #include "vfs_default.h" VFS_AUTO_MOUNT(littlefs2, VFS_MTD(banglejs2_nor_dev), VFS_DEFAULT_NVM(0), 0); #endif

here and

ifneq (,$(filter vfs_default,$(USEMODULE))) USEPKG += littlefs2 USEMODULE += mtd endif

to Makefile.dep

benpicco · 2022-09-04T23:39:25Z

boards/banglejs-2/banglejs2-pinout.txt

@@ -0,0 +1,102 @@
+Bangle.js 2 - Pinout


This should go to doc.txt

benpicco · 2022-09-04T23:40:19Z

boards/banglejs-2/include/periph_conf.h

+        .dev  = NRF_SPIM2,
+        .sclk = LCD_SCK,
+        .mosi = LCD_MOSI,
+        //.miso = GPIO_UNDEF,


better set .miso = GPIO_UNDEF, since GPIO_UNDEF is not necessarily 0.

maribu

Looks good to me. Some comments inline, mostly style nitpicks.

maribu · 2022-09-05T03:19:39Z

boards/banglejs-2/board.c

+#include "timex.h"
+#include "ztimer.h"
+
+


Suggested change

The CI dislikes more than one consecutive blank line

maribu · 2022-09-05T03:20:08Z

boards/banglejs-2/board.c

+static const mtd_spi_nor_params_t _banglejs2_nor_params = {
+    .opcode = &mtd_spi_nor_opcode_default,
+    .wait_chip_erase = 9LU * US_PER_SEC,
+    .wait_32k_erase = 160LU *US_PER_MS,


Suggested change

.wait_32k_erase = 160LU *US_PER_MS,

.wait_32k_erase = 160LU * US_PER_MS,

maribu · 2022-09-05T03:20:50Z

boards/banglejs-2/board.c

+mtd_dev_t *mtd0 = (mtd_dev_t *)&banglejs2_nor_dev;
+#endif /* MODULE_MTD */
+
+


Suggested change

maribu · 2022-09-05T03:24:13Z

boards/banglejs-2/board.c

+    }
+
+    if (pwm_init(PWM_DEV(1), PWM_RIGHT, 1250, 100) > 0) {
+        pwm_set(PWM_DEV(1), 0, 50); /* 50% duty cylce @ 125kHz for EXTCOM ? */


This will likely contribute to power consumption. I am not sure how PWM is implemented on the nRF5x, but mostly a high frequency timer peripheral is used. This in turn leads to the PLL generating the CPU clock remaining active.

maribu · 2022-09-05T03:26:53Z

boards/banglejs-2/board.c

+    /* power off peripherals as much as we can */
+    gpio_clear(LCD_DISP);
+    pwm_poweroff(PWM_DEV(0)); /* LCD ExtCOM */
+    pwm_poweroff(PWM_DEV(1)); /* LCD backlight */


The comments regarding LCD extcom / backlight are in reverse order compared to the init functions. I didn't check which one is correct.

maribu · 2022-09-05T03:49:13Z

boards/banglejs-2/include/periph_conf.h

+    // LCD backlight
+    { NRF_PWM0, { LCD_BACKLIGHT, GPIO_UNDEF, GPIO_UNDEF, GPIO_UNDEF } },
+    // LCD EXTCOM
+    { NRF_PWM1, { LCD_EXTCOMIN, GPIO_UNDEF, GPIO_UNDEF, GPIO_UNDEF } },


I wonder if the LCD backlight and ghe LCD EXTCOM couldbe driven from the same PWM device, just as channel 0 and channel 1. This would of course only work if the same frequency would work with both. But it may make handling easier, if those need to be enabled simultaneously anyway.

maribu · 2022-09-05T03:49:33Z

boards/banglejs-2/include/periph_conf.h

+ * @{
+ */
+static const pwm_conf_t pwm_config[] = {
+    // LCD backlight


Suggested change

// LCD backlight

/* LCD backlight */

maribu · 2022-09-05T03:49:47Z

boards/banglejs-2/include/periph_conf.h

+static const pwm_conf_t pwm_config[] = {
+    // LCD backlight
+    { NRF_PWM0, { LCD_BACKLIGHT, GPIO_UNDEF, GPIO_UNDEF, GPIO_UNDEF } },
+    // LCD EXTCOM


Suggested change

// LCD EXTCOM

/* LCD EXTCOM */

maribu · 2022-09-05T03:50:01Z

boards/banglejs-2/include/periph_conf.h

+    { NRF_PWM0, { LCD_BACKLIGHT, GPIO_UNDEF, GPIO_UNDEF, GPIO_UNDEF } },
+    // LCD EXTCOM
+    { NRF_PWM1, { LCD_EXTCOMIN, GPIO_UNDEF, GPIO_UNDEF, GPIO_UNDEF } },
+    // vibration motor


Suggested change

// vibration motor

/* vibration motor */

maribu · 2022-09-05T03:50:10Z

boards/banglejs-2/include/periph_conf.h

+#define PWM_NUMOF           ARRAY_SIZE(pwm_config)
+
+/** @} */
+


Suggested change

benpicco · 2022-10-05T09:43:03Z

@nica-f ping 😉

benpicco · 2023-02-17T12:03:46Z

Should we take over this PR?

OlegHahm · 2023-03-06T16:20:10Z

boards/banglejs-2/Makefile.include

@@ -0,0 +1,13 @@
+# use JLink Segger RTT by default
+RIOT_TERMINAL ?= jlink


Shouldn't this be openocd-rtt?

Add Bangle.JS2 smart watch board support

5cda74b

boards: bangle-js2, remove no more needed module boards: bangle/js2, remove sector count, will get auto detected boards: bangle-js2, reformat comments for coding style boards: bangle-js2, remove unnecessary definition of openocd

nica-f requested review from leandrolanzieri, jia200x and MrKevinWeiss as code owners September 4, 2022 23:06

github-actions bot added Area: boards Area: Board ports Area: doc Area: Documentation Area: Kconfig Area: Kconfig integration labels Sep 4, 2022

benpicco requested a review from maribu September 4, 2022 23:32

benpicco reviewed Sep 4, 2022

View reviewed changes

maribu reviewed Sep 5, 2022

View reviewed changes

benpicco requested a review from OlegHahm October 25, 2022 21:35

OlegHahm reviewed Mar 6, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Bangle.JS2 smart watch board support #18554

Add Bangle.JS2 smart watch board support #18554

nica-f commented Sep 4, 2022

benpicco left a comment

benpicco Sep 4, 2022

benpicco Sep 4, 2022

benpicco Sep 4, 2022

benpicco Sep 4, 2022

benpicco Sep 4, 2022

maribu left a comment •

edited

Loading

maribu Sep 5, 2022

maribu Sep 5, 2022

maribu Sep 5, 2022

maribu Sep 5, 2022

maribu Sep 5, 2022

maribu Sep 5, 2022

maribu Sep 5, 2022

maribu Sep 5, 2022

maribu Sep 5, 2022

maribu Sep 5, 2022

benpicco commented Oct 5, 2022

benpicco commented Feb 17, 2023

OlegHahm Mar 6, 2023 •

edited

Loading

	.wait_32k_erase = 160LU *US_PER_MS,
	.wait_32k_erase = 160LU * US_PER_MS,

		mtd_dev_t mtd0 = (mtd_dev_t )&banglejs2_nor_dev;
		#endif /* MODULE_MTD */

		@@ -0,0 +1,13 @@
		# use JLink Segger RTT by default
		RIOT_TERMINAL ?= jlink

		#define PWM_NUMOF ARRAY_SIZE(pwm_config)

		/** @} */

Add Bangle.JS2 smart watch board support #18554

Are you sure you want to change the base?

Add Bangle.JS2 smart watch board support #18554

Conversation

nica-f commented Sep 4, 2022

benpicco left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

maribu left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

benpicco commented Oct 5, 2022

benpicco commented Feb 17, 2023

OlegHahm Mar 6, 2023 • edited Loading

Choose a reason for hiding this comment

maribu left a comment •

edited

Loading

OlegHahm Mar 6, 2023 •

edited

Loading