Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drivers/kw2xrd/Kconfig: fix kconfig model #18497

Merged
merged 2 commits into from
Aug 23, 2022

Conversation

MrKevinWeiss
Copy link
Contributor

Contribution description

Nightlies are currently failing as there is a difference between make
and kconfig.
This tries to match the kconfig with the makefile dep.
The only issue is the

ifneq (,$(filter netdev,$(USEMODULE)))
  USEMODULE += netdev_ieee802154_submac
endif

which may have the same effect as select
HAVE_IEEE802154_RADIO_HAL_INTERFACE.

Testing procedure

NIGHTLY=1 /bin/bash -c "source .murdock; JOBS=4 compile tests/ieee802154_hal pba-d-01-kw2x:gnu" should pass.

Issues/PRs references

Follow-up from #18469

@github-actions github-actions bot added Area: drivers Area: Device drivers Area: Kconfig Area: Kconfig integration labels Aug 22, 2022
@MrKevinWeiss
Copy link
Contributor Author

Like I said, maybe the following should also be in

diff --git a/boards/pba-d-01-kw2x/Kconfig b/boards/pba-d-01-kw2x/Kconfig
index 8068c000ca..5307eb8a25 100644
--- a/boards/pba-d-01-kw2x/Kconfig
+++ b/boards/pba-d-01-kw2x/Kconfig
@@ -28,3 +28,4 @@ config BOARD_PBA_D_01_KW2X
     select HAVE_MPL3115A2
     select HAVE_TCS37727
     select HAVE_TMP006
+    select HAVE_IEEE802154_RADIO_HAL_INTERFACE

If @jia200x could have a quick look and confirm?

Comment on lines -19 to -21
select MODULE_NETDEV
select MODULE_NETDEV_IEEE802154
select MODULE_NETDEV_LEGACY_API
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since those should already be provided by the submac netdev, the removal here is correct either way.

@github-actions github-actions bot added the Area: CI Area: Continuous Integration of RIOT components label Aug 22, 2022
@MrKevinWeiss
Copy link
Contributor Author

I also added this board to the kconfig test in the .murdock so it won't be just nightlies that check it.

@MrKevinWeiss
Copy link
Contributor Author

Just waiting for an opinion on HAVE_IEEE802154_RADIO_HAL_INTERFACE since there is a visible difference in the makefile.dep

@benpicco
Copy link
Contributor

Why would a board select this? HAVE_IEEE802154_RADIO_HAL_INTERFACE is a property of the radio driver.

@MrKevinWeiss
Copy link
Contributor Author

I thought the radio is tied to the board... @jia200x is in now and I can discuss.

@benpicco
Copy link
Contributor

The radio is tied to the board, but HAVE_IEEE802154_RADIO_HAL_INTERFACE should be tied to the radio, as it's done with cc2538, nrf802154 and socket_zep.

@MrKevinWeiss
Copy link
Contributor Author

Maybe the MODULE_KW2XRF selecting it makes more sense. Ok, pushed the fixup.

@MrKevinWeiss MrKevinWeiss added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Aug 22, 2022
Nightlies are currently failing as there is a difference between make
and kconfig.
This tries to match the kconfig with the makefile dep.
The only issue is the
```
ifneq (,$(filter netdev,$(USEMODULE)))
  USEMODULE += netdev_ieee802154_submac
endif
```

which may have the same effect as select
HAVE_IEEE802154_RADIO_HAL_INTERFACE.
@MrKevinWeiss
Copy link
Contributor Author

I guess it looks good. I squashed and removed the build limiting.

@benpicco benpicco merged commit bc82cf1 into RIOT-OS:master Aug 23, 2022
@MrKevinWeiss MrKevinWeiss deleted the pr/fix/ieeehal branch August 23, 2022 13:22
@MrKevinWeiss
Copy link
Contributor Author

Thanks for the review!

@maribu maribu added this to the Release 2022.10 milestone Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: CI Area: Continuous Integration of RIOT components Area: drivers Area: Device drivers Area: Kconfig Area: Kconfig integration CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants