-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
drivers/kw2xrd/Kconfig: fix kconfig model #18497
Conversation
Like I said, maybe the following should also be in diff --git a/boards/pba-d-01-kw2x/Kconfig b/boards/pba-d-01-kw2x/Kconfig
index 8068c000ca..5307eb8a25 100644
--- a/boards/pba-d-01-kw2x/Kconfig
+++ b/boards/pba-d-01-kw2x/Kconfig
@@ -28,3 +28,4 @@ config BOARD_PBA_D_01_KW2X
select HAVE_MPL3115A2
select HAVE_TCS37727
select HAVE_TMP006
+ select HAVE_IEEE802154_RADIO_HAL_INTERFACE
If @jia200x could have a quick look and confirm? |
select MODULE_NETDEV | ||
select MODULE_NETDEV_IEEE802154 | ||
select MODULE_NETDEV_LEGACY_API |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since those should already be provided by the submac netdev, the removal here is correct either way.
I also added this board to the kconfig test in the .murdock so it won't be just nightlies that check it. |
Just waiting for an opinion on |
Why would a board select this? |
I thought the radio is tied to the board... @jia200x is in now and I can discuss. |
The radio is tied to the board, but |
Maybe the |
Nightlies are currently failing as there is a difference between make and kconfig. This tries to match the kconfig with the makefile dep. The only issue is the ``` ifneq (,$(filter netdev,$(USEMODULE))) USEMODULE += netdev_ieee802154_submac endif ``` which may have the same effect as select HAVE_IEEE802154_RADIO_HAL_INTERFACE.
5e79ec2
to
6527408
Compare
I guess it looks good. I squashed and removed the build limiting. |
Thanks for the review! |
Contribution description
Nightlies are currently failing as there is a difference between make
and kconfig.
This tries to match the kconfig with the makefile dep.
The only issue is the
which may have the same effect as select
HAVE_IEEE802154_RADIO_HAL_INTERFACE.
Testing procedure
NIGHTLY=1 /bin/bash -c "source .murdock; JOBS=4 compile tests/ieee802154_hal pba-d-01-kw2x:gnu"
should pass.Issues/PRs references
Follow-up from #18469