Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/periph_spi: print rx-buffer on slave #1826

Merged

Conversation

PeterKietzmann
Copy link
Member

This PR adds a shell command to the SPI-test that enables an SPI-slave device to print the receive buffer.

@OlegHahm OlegHahm added Area: drivers Area: Device drivers Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation Area: tests Area: tests and testing framework labels Oct 20, 2014
}

rx_counter = 0;
for (int i = 0; i < 256; i++) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should use memset() instead of this loop.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I addressed this.

@haukepetersen
Copy link
Contributor

ACK when squashed
Interestingly Travis is running now for more then 24h... :-)

@PeterKietzmann
Copy link
Member Author

Hehe, ok let's see how long it takes him now!

@haukepetersen
Copy link
Contributor

ah, he is happy. And go.

haukepetersen added a commit that referenced this pull request Nov 6, 2014
tests/periph_spi: print rx-buffer on slave
@haukepetersen haukepetersen merged commit 7156846 into RIOT-OS:master Nov 6, 2014
@PeterKietzmann PeterKietzmann deleted the extend_test_periph_spi branch March 26, 2015 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: drivers Area: Device drivers Area: tests Area: tests and testing framework Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants