unittests: fix assertion for nanocoap_cache_key_compare() #18125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The doc states only that the result is <0, not -1. The result isn't the latter for some platforms (see https://github.com/RIOT-OS/RIOT/runs/6534330788?check_suite_focus=true#step:13:696)
miri64
added
the
Type: bug
benpicco
added
the
CI: ready for build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
The doc states only that the result is <0, not -1. The result isn't the latter for some platforms (see https://github.com/RIOT-OS/RIOT/runs/6534330788?check_suite_focus=true#step:13:696)
Testing procedure
Run unittests on e.g. an ARM-Cortex-based platform. On my system there is another failure for
tests-pktATM which I will also investigate.Issues/PRs references
None, showed up in weekly release tests.