Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-tests: install libasan as native dependency #18124

Merged
merged 2 commits into from
May 23, 2022
Merged

release-tests: install libasan as native dependency #18124

merged 2 commits into from
May 23, 2022

Conversation

miri64
Copy link
Member

@miri64 miri64 commented May 23, 2022

Contribution description

See #18099 and https://github.com/RIOT-OS/RIOT/runs/6534330826?check_suite_focus=true

Testing procedure

Will start a standalone release test.

Issues/PRs references

Follow-up on #18099.

@miri64 miri64 added the Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) label May 23, 2022
@github-actions github-actions bot added the Area: CI Area: Continuous Integration of RIOT components label May 23, 2022
@miri64
Copy link
Member Author

miri64 commented May 23, 2022 •
edited
Loading

Will start a standalone release test.

See https://github.com/RIOT-OS/RIOT/actions/runs/2370260804 (sorry wrong base yml file) https://github.com/miri64/RIOT/actions/runs/2370286690 (32-bit lib was needed) https://github.com/miri64/RIOT/runs/6552855739?check_suite_focus=true

@miri64 miri64 force-pushed the release-tests/fix/install-libasan branch from 44c6656 to bd2daad Compare May 23, 2022 09:49
@miri64 miri64 marked this pull request as ready for review May 23, 2022 09:55
kaspar030
kaspar030 approved these changes May 23, 2022
View reviewed changes
Copy link
Contributor

@kaspar030 kaspar030 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK.

@github-actions github-actions bot added Area: boards Area: Board ports Area: doc Area: Documentation Platform: native Platform: This PR/issue effects the native platform labels May 23, 2022
@miri64
Copy link
Member Author

miri64 commented May 23, 2022

Piggy-backed a doc update for that new dependency.

kaspar030
kaspar030 approved these changes May 23, 2022
View reviewed changes
Copy link
Contributor

@kaspar030 kaspar030 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK.

@kaspar030 kaspar030 added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label May 23, 2022
@miri64 miri64 merged commit 37db22e into RIOT-OS:master May 23, 2022
@miri64 miri64 deleted the release-tests/fix/install-libasan branch May 23, 2022 10:20
@chrysn chrysn added this to the Release 2022.07 milestone Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaspar030 kaspar030 kaspar030 approved these changes

Assignees
No one assigned
Labels
Area: boards Area: Board ports Area: CI Area: Continuous Integration of RIOT components Area: doc Area: Documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: native Platform: This PR/issue effects the native platform Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Milestone
Release 2022.07
Development

Successfully merging this pull request may close these issues.
3 participants
@miri64 @kaspar030 @chrysn