Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg/spiffs: hook up .stat() #17971

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

pkg/spiffs: hook up .stat() #17971

wants to merge 1 commit into from
+23 −9

Conversation

benpicco
Copy link
Contributor

Contribution description

This wires up the SPIFFS_stat() function to vfs_stat().

Testing procedure

Issues/PRs references

@benpicco benpicco added Area: fs Area: File systems CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Apr 20, 2022
@github-actions github-actions bot added the Area: pkg Area: External package ports label Apr 20, 2022
@benpicco benpicco requested a review from chrysn April 20, 2022 20:22
@benpicco benpicco added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Apr 20, 2022
@benpicco benpicco requested review from fjmolinas and maribu April 29, 2022 20:25
@benpicco benpicco requested a review from kfessel May 10, 2022 08:20
kfessel
kfessel reviewed May 10, 2022
View reviewed changes
pkg/spiffs/fs/spiffs_fs.c Outdated Show resolved Hide resolved
@benpicco benpicco removed the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label May 10, 2022
@benpicco benpicco added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels May 16, 2022
@benpicco benpicco requested a review from fabian18 May 30, 2022 11:56
@fjmolinas
Copy link
Contributor

Can you provide some test output?

@benpicco
Copy link
Contributor Author

benpicco commented May 31, 2022 •
edited
Loading

master

> vfs w /nvm0/foo.txt ascii o "Hello SPIFFS"
> ls /nvm0
/foo.txt/

this PR

> ls /nvm0
/foo.txt	134627328

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kfessel kfessel kfessel left review comments

@chrysn chrysn Awaiting requested review from chrysn

@fjmolinas fjmolinas Awaiting requested review from fjmolinas

@maribu maribu Awaiting requested review from maribu

@fabian18 fabian18 Awaiting requested review from fabian18

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Area: fs Area: File systems Area: pkg Area: External package ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@benpicco @fjmolinas @chrysn @kfessel