Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: small fix of "Getting Started" document structure in section docker #17756

Merged
merged 2 commits into from
Mar 7, 2022

Conversation

gschorcht
Copy link
Contributor

Contribution description

This PR fixes the following problems:

  • Section "Usage" which describes the usage of docker is on heading level 1 but has to be on heading level 2.
  • Section "Setup" has only one subsection. A second subsection is added. Now, the section "Setup" has two subsections, one that describes the installation of docker and one that describes downloading and testing of the RIOT docker build image.
  • Backticks in headings no longer seem to work in doxygen markdown support.

screenshot_001

Testing procedure

make doc should give the following results for doc/doxygen/html/getting-started.html

screenshot_002

Issues/PRs references

@github-actions github-actions bot added the Area: doc Area: Documentation label Mar 6, 2022
@gschorcht gschorcht added CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation labels Mar 6, 2022
@gschorcht gschorcht force-pushed the doc/fix_getitng_started_docker branch from ee9f494 to 4fc8ba3 Compare March 6, 2022 14:27
Comment on lines 326 to 327
Usage
-------
Copy link
Contributor

@aabadie aabadie Mar 6, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Usage
-------
Usage
-----

(You can squash directly)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Contributor

@aabadie aabadie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirm the issue and that it's fixed by this PR. Please squash the small nit above (or just ignore if you prefer).

ACK

Fixes two problems:
- Section "Usage" which describes the usage of docker is on heading level 1 but has to be on  heading level 2
- Section "Setup" has only one subsection. A second subsection was added. Now, the section "Setup" has two subsections, one that describes the installation of docker and one that describes downloading and testing of the RIOT docker build image.
Backticks in headings no longer seem to work in doxygen markdown support.
@gschorcht gschorcht added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Mar 6, 2022
@gschorcht gschorcht force-pushed the doc/fix_getitng_started_docker branch from 4fc8ba3 to 4220f65 Compare March 6, 2022 22:42
@aabadie aabadie merged commit 7e587b0 into RIOT-OS:master Mar 7, 2022
@gschorcht
Copy link
Contributor Author

Thanks for reviewing and merging.

@OlegHahm OlegHahm added this to the Release 2022.04 milestone Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: doc Area: Documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants