Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cpu/esp32/esp-eth: move GNRC auto_init to init_devs #17745

Merged
merged 1 commit into from
Mar 7, 2022
Merged

cpu/esp32/esp-eth: move GNRC auto_init to init_devs #17745

merged 1 commit into from
Mar 7, 2022

Conversation

leandrolanzieri
Copy link
Contributor

Contribution description

This moves the GNRC auto_init of ESP32 ethernet peripheral driver to init_devs, where all the other drivers are initialized.

Testing procedure

  • Test some GNRC-based example while using esp_eth module

Issues/PRs references

Split from #17739

@leandrolanzieri leandrolanzieri added the Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation label Mar 4, 2022
@leandrolanzieri leandrolanzieri requested a review from benpicco March 4, 2022 07:57
@github-actions github-actions bot added Area: cpu Area: CPU/MCU ports Area: network Area: Networking Area: sys Area: System Platform: ESP Platform: This PR/issue effects ESP-based platforms labels Mar 4, 2022
@gschorcht
Copy link
Contributor

@leandrolanzieri Please quash.

gschorcht
gschorcht approved these changes Mar 4, 2022
View reviewed changes
Copy link
Contributor

@gschorcht gschorcht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, still works as expected.

@leandrolanzieri leandrolanzieri force-pushed the cpu/esp32/esp-eth/move_auto_init branch from 10e3050 to 74c8893 Compare March 4, 2022 08:41
@leandrolanzieri leandrolanzieri added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Mar 4, 2022
@benpicco benpicco enabled auto-merge March 4, 2022 11:35
@benpicco benpicco added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Mar 4, 2022
@gschorcht gschorcht added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Mar 7, 2022
@leandrolanzieri leandrolanzieri added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Mar 7, 2022
@benpicco benpicco added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Mar 7, 2022
@benpicco benpicco merged commit 2d89399 into RIOT-OS:master Mar 7, 2022
@leandrolanzieri leandrolanzieri deleted the cpu/esp32/esp-eth/move_auto_init branch March 7, 2022 19:39
@leandrolanzieri
Copy link
Contributor Author

Thanks @gschorcht for reviewing and testing this one!

@leandrolanzieri leandrolanzieri mentioned this pull request Mar 8, 2022
Merged
@OlegHahm OlegHahm added this to the Release 2022.04 milestone Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gschorcht gschorcht gschorcht approved these changes

@benpicco benpicco Awaiting requested review from benpicco

@miri64 miri64 Awaiting requested review from miri64 miri64 is a code owner

@haukepetersen haukepetersen Awaiting requested review from haukepetersen

@PeterKietzmann PeterKietzmann Awaiting requested review from PeterKietzmann PeterKietzmann is a code owner

@cgundogan cgundogan Awaiting requested review from cgundogan

Assignees
No one assigned
Labels
Area: cpu Area: CPU/MCU ports Area: network Area: Networking Area: sys Area: System CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: ESP Platform: This PR/issue effects ESP-based platforms Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation
Projects
None yet
Milestone
Release 2022.04
Development

Successfully merging this pull request may close these issues.
4 participants
@leandrolanzieri @gschorcht @benpicco @OlegHahm