Skip to content

kconfig explore all allowed boards on all apps #17595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 8, 2022
Merged

kconfig explore all allowed boards on all apps #17595

merged 2 commits into from
Feb 8, 2022

Conversation

MrKevinWeiss
Copy link
Contributor

@MrKevinWeiss MrKevinWeiss commented Feb 1, 2022 •
edited
Loading

Contribution description

Run all non-blockisted boards for every kconfig enabled app only during nightlies.
This should find any corner cases slipping through the regular testing (currently only one on the ublox-c030-u201 board due to incorrect makefile modelling). This should also have no impact on regular CI times, only the nightly will be longer (since it will eventually double the jobs).

Testing procedure

Check to see that the removeme commit, forcing nightly, tests a board that would not normally be tested for kconfig.

Issues/PRs references

@MrKevinWeiss MrKevinWeiss added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: full build disable CI build filter labels Feb 1, 2022
@github-actions github-actions bot added Area: CI Area: Continuous Integration of RIOT components Area: boards Area: Board ports labels Feb 1, 2022
@MrKevinWeiss
Copy link
Contributor Author

Well surprisingly things are looking very good. The only issue was with the ublox-c030-u201 makefile.dep modelling. I think it just wasn't done correctly.

I removed it and added now think we can run all tests on all non-blocklisted boards for the nightlies. I added a removeme commit to test if the nightly flag would actually run it properly.

@MrKevinWeiss
Copy link
Contributor Author

MrKevinWeiss commented Feb 2, 2022 •
edited by fjmolinas
Loading

This shows that the ublox-c030-u201 was tested for kconfig on tests/vfs_plus_stdio. Since that board is not in the TEST_KCONFIG_BOARDS_AVAILABLE.

-- running on worker mobi6.inet.haw-hamburg.de-13 thread 1, build number 150303.
make: Entering directory '/tmp/dwq.0.3734573280100304/736ebaebce22769fd9d4bca87350d3ab/tests/vfs_plus_stdio'
make: Leaving directory '/tmp/dwq.0.3734573280100304/736ebaebce22769fd9d4bca87350d3ab/tests/vfs_plus_stdio'
make: Entering directory '/tmp/dwq.0.3734573280100304/736ebaebce22769fd9d4bca87350d3ab/tests/vfs_plus_stdio'
[INFO] cloning stm32cmsis
Building application "tests_vfs_plus_stdio" for "ublox-c030-u201" with MCU "stm32".

git-cache: cloning from cache. tag=commit6fe2c1f498feda34ee422720ff8b3bd1b4656145-926375
[INFO] updating stm32cmsis /tmp/dwq.0.3734573280100304/736ebaebce22769fd9d4bca87350d3ab/build/stm32/cmsis/f4/.pkg-state.git-downloaded
echo 6fe2c1f498feda34ee422720ff8b3bd1b4656145   > /tmp/dwq.0.3734573280100304/736ebaebce22769fd9d4bca87350d3ab/build/stm32/cmsis/f4/.pkg-state.git-downloaded
[INFO] patch stm32cmsis
sha1sum /tmp/dwq.0.3734573280100304/736ebaebce22769fd9d4bca87350d3ab/tests/vfs_plus_stdio/tests/01-run.py /tmp/dwq.0.3734573280100304/736ebaebce22769fd9d4bca87350d3ab/build/tests_vfs_plus_stdio.elf > /tmp/dwq.0.3734573280100304/736ebaebce22769fd9d4bca87350d3ab/build/test-input-hash.sha1
   text	   data	    bss	    dec	    hex	filename
  10072	    160	   2788	  13020	   32dc	/tmp/dwq.0.3734573280100304/736ebaebce22769fd9d4bca87350d3ab/build/tests_vfs_plus_stdio.elf
make: Leaving directory '/tmp/dwq.0.3734573280100304/736ebaebce22769fd9d4bca87350d3ab/tests/vfs_plus_stdio'
make: Entering directory '/tmp/dwq.0.3734573280100304/736ebaebce22769fd9d4bca87350d3ab/tests/vfs_plus_stdio'
Building application "tests_vfs_plus_stdio" for "ublox-c030-u201" with MCU "stm32".

[INFO] cloning stm32cmsis
git-cache: cloning from cache. tag=commit6fe2c1f498feda34ee422720ff8b3bd1b4656145-927115
[INFO] updating stm32cmsis /tmp/dwq.0.3734573280100304/736ebaebce22769fd9d4bca87350d3ab/build/stm32/cmsis/f4/.pkg-state.git-downloaded
echo 6fe2c1f498feda34ee422720ff8b3bd1b4656145   > /tmp/dwq.0.3734573280100304/736ebaebce22769fd9d4bca87350d3ab/build/stm32/cmsis/f4/.pkg-state.git-downloaded
[INFO] patch stm32cmsis
sha1sum /tmp/dwq.0.3734573280100304/736ebaebce22769fd9d4bca87350d3ab/tests/vfs_plus_stdio/tests/01-run.py /tmp/dwq.0.3734573280100304/736ebaebce22769fd9d4bca87350d3ab/build/tests_vfs_plus_stdio.elf > /tmp/dwq.0.3734573280100304/736ebaebce22769fd9d4bca87350d3ab/build/test-input-hash.sha1
   text	   data	    bss	    dec	    hex	filename
  10072	    160	   2788	  13020	   32dc	/tmp/dwq.0.3734573280100304/736ebaebce22769fd9d4bca87350d3ab/build/tests_vfs_plus_stdio.elf
make: Leaving directory '/tmp/dwq.0.3734573280100304/736ebaebce22769fd9d4bca87350d3ab/tests/vfs_plus_stdio'
-- build directory size: 30M

@MrKevinWeiss
Copy link
Contributor Author

Before removing the "REMOVEME" commit, it would be nice to complete the review as it will delete the link indicating nightly does actually perform the tests. Of course, I squash, rebase, and remove the commit, it should indicate that the ublox board is not tested.

ping @leandrolanzieri @fjmolinas or @kaspar030

@fjmolinas
Copy link
Contributor

Can you explain a bit more what 51c3062 commit is doing?

@MrKevinWeiss
Copy link
Contributor Author

I guess it is easier to look at it after the fixup. This was my initial commit that removed the TEST_KCONFIG_BOARDS_AVAILABLE and just tested everything. I didn't actually think everything would work out so well. The fixup brings the list back so that normal behaviour is returned with the exception of nightlies.

@fjmolinas
Copy link
Contributor

I guess it is easier to look at it after the fixup. This was my initial commit that removed the TEST_KCONFIG_BOARDS_AVAILABLE and just tested everything. I didn't actually think everything would work out so well. The fixup brings the list back so that normal behaviour is returned with the exception of nightlies.

Makes sense, I checked that the test was run, inlined the result in your comments as well. Please squash @MrKevinWeiss!

fjmolinas
fjmolinas approved these changes Feb 7, 2022
View reviewed changes
Copy link
Contributor

@fjmolinas fjmolinas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@MrKevinWeiss
Copy link
Contributor Author

Let me just post a link to the test result from murdock before we merge.

@MrKevinWeiss
Copy link
Contributor Author

Here we can see the test did not check kconfig, which is expected as the nightly flag is removed.... It seems like I left a whitespace in so I will have to rerun again after force pushing. I will paste the output so it isn't lost

-- running on worker mobi6.inet.haw-hamburg.de-29 thread 1, build number 23694.
make: Entering directory '/tmp/dwq.0.37122795518331686/9c103be8cddcce0f798aa21cae89eff9/tests/vfs_plus_stdio'
Building application "tests_vfs_plus_stdio" for "ublox-c030-u201" with MCU "stm32".

[INFO] cloning stm32cmsis
git-cache: cloning from cache. tag=commit6fe2c1f498feda34ee422720ff8b3bd1b4656145-2917256
[INFO] updating stm32cmsis /tmp/dwq.0.37122795518331686/9c103be8cddcce0f798aa21cae89eff9/build/stm32/cmsis/f4/.pkg-state.git-downloaded
echo 6fe2c1f498feda34ee422720ff8b3bd1b4656145   > /tmp/dwq.0.37122795518331686/9c103be8cddcce0f798aa21cae89eff9/build/stm32/cmsis/f4/.pkg-state.git-downloaded
[INFO] patch stm32cmsis
sha1sum /tmp/dwq.0.37122795518331686/9c103be8cddcce0f798aa21cae89eff9/tests/vfs_plus_stdio/tests/01-run.py /tmp/dwq.0.37122795518331686/9c103be8cddcce0f798aa21cae89eff9/build/tests_vfs_plus_stdio.elf > /tmp/dwq.0.37122795518331686/9c103be8cddcce0f798aa21cae89eff9/build/test-input-hash.sha1
   text	   data	    bss	    dec	    hex	filename
  10072	    160	   2788	  13020	   32dc	/tmp/dwq.0.37122795518331686/9c103be8cddcce0f798aa21cae89eff9/build/tests_vfs_plus_stdio.elf
make: Leaving directory '/tmp/dwq.0.37122795518331686/9c103be8cddcce0f798aa21cae89eff9/tests/vfs_plus_stdio'
-- build directory size: 30M

@MrKevinWeiss
boards/ublox-c030-u201: Remove vfs make dep
514ea77 
This modelling doesn't seem correct and probably shouldn't be in here.
Normally vfs modelling shouldn't be handled in the boards.
Even if it was the mtd modelling is also not correct.
@MrKevinWeiss MrKevinWeiss merged commit 648c6bc into RIOT-OS:master Feb 8, 2022
@MrKevinWeiss MrKevinWeiss deleted the pr/explorekconfig branch February 8, 2022 07:46
@OlegHahm OlegHahm added this to the Release 2022.04 milestone Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fjmolinas fjmolinas fjmolinas approved these changes

@kaspar030 kaspar030 Awaiting requested review from kaspar030 kaspar030 is a code owner

Assignees
No one assigned
Labels
Area: boards Area: Board ports Area: CI Area: Continuous Integration of RIOT components CI: full build disable CI build filter CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR
Projects
None yet
Milestone
Release 2022.04
Development

Successfully merging this pull request may close these issues.
3 participants
@MrKevinWeiss @fjmolinas @OlegHahm