Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

murdock: support emulated boards #17434

Merged
merged 2 commits into from
Apr 6, 2022
Merged

murdock: support emulated boards #17434

merged 2 commits into from
Apr 6, 2022

Conversation

kaspar030
Copy link
Contributor

@kaspar030 kaspar030 commented Dec 21, 2021 •
edited
Loading

Contribution description

This PR adds support for emulated boards to .murdock.

Emulated boards need to be whitelisted (by adding them to .murdock's EMULATED_BOARDS_AVAILABLE).
Tests will be run for them on the build workers, similar to native.

microbit is added as first candidate.

This requires and is waiting for RIOT-OS/riotdocker#168. (merged)

I'm expecting some tests to fail on the emulated microbit, as the emulation is not complete.
I'll add those to the CI blacklist, probably guarded by "EMULATE=1".

All failing tests have been CI test blacklisted. I've created a tracking issue: #17894

Testing procedure

CI should be fine.

Issues/PRs references

This is stumbling over #17555. (resolved)

@kaspar030 kaspar030 added State: waiting for CI update State: The PR requires an Update to CI to be performed first State: WIP State: The PR is still work-in-progress and its code is not in its final presentable form yet labels Dec 21, 2021
@github-actions github-actions bot added the Area: CI Area: Continuous Integration of RIOT components label Dec 21, 2021
@kaspar030 kaspar030 added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed State: waiting for CI update State: The PR requires an Update to CI to be performed first labels Dec 22, 2021
@kaspar030 kaspar030 mentioned this pull request Jan 24, 2022
Closed
@kaspar030 kaspar030 added the State: waiting for other PR State: The PR requires another PR to be merged first label Jan 24, 2022
@fjmolinas fjmolinas added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Mar 4, 2022
@kaspar030 kaspar030 added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR State: waiting for other PR State: The PR requires another PR to be merged first labels Apr 1, 2022
@github-actions github-actions bot added the Area: tests Area: tests and testing framework label Apr 1, 2022
@kaspar030 kaspar030 mentioned this pull request Apr 1, 2022
Open
47 tasks
@kaspar030 kaspar030 removed the State: WIP State: The PR is still work-in-progress and its code is not in its final presentable form yet label Apr 1, 2022
@kfessel
Copy link
Contributor

kfessel commented Apr 6, 2022 •
edited
Loading

tests are run:
https://ci.riot-os.org/RIOT-OS/RIOT/17434/c4bba0e65dce98e4056fe62d1e561a85848a6387/output/compile/tests/cb_mux/microbit:gnu.txt
https://ci.riot-os.org/RIOT-OS/RIOT/17434/c4bba0e65dce98e4056fe62d1e561a85848a6387/output/compile/tests/bench_sched_nop/microbit:gnu.txt

native is still working :
https://ci.riot-os.org/RIOT-OS/RIOT/17434/c4bba0e65dce98e4056fe62d1e561a85848a6387/output/compile/tests/bench_sched_nop/native:gnu.txt

@kaspar030
Copy link
Contributor Author

Yup! Unfortunately our tests don't print the stack output in some (most?) cases, but that's also the case for "real" boards, so not related to this PR.

kfessel
kfessel approved these changes Apr 6, 2022
View reviewed changes
Copy link
Contributor

@kfessel kfessel left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR does what it claims to do. (add emulation run test to murdock)

code reads good

and (RUN_TESTS and native are still working)

@kaspar030 kaspar030 merged commit 031ed1e into RIOT-OS:master Apr 6, 2022
@kaspar030 kaspar030 deleted the murdock_use_emulators branch April 6, 2022 12:41
@kaspar030
Copy link
Contributor Author

Thanks!

@OlegHahm OlegHahm added this to the Release 2022.04 milestone Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kfessel kfessel kfessel approved these changes

@miri64 miri64 Awaiting requested review from miri64

@smlng smlng Awaiting requested review from smlng

@leandrolanzieri leandrolanzieri Awaiting requested review from leandrolanzieri leandrolanzieri is a code owner

@aabadie aabadie Awaiting requested review from aabadie aabadie is a code owner

@MichelRottleuthner MichelRottleuthner Awaiting requested review from MichelRottleuthner MichelRottleuthner is a code owner

@fjmolinas fjmolinas Awaiting requested review from fjmolinas

Assignees
No one assigned
Labels
Area: CI Area: Continuous Integration of RIOT components Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR
Projects
None yet
Milestone
Release 2022.04
Development

Successfully merging this pull request may close these issues.
4 participants
@kaspar030 @kfessel @OlegHahm @fjmolinas