-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cpu: do not auto-select ztimer_periph_rtt for sam0, fe310 #17395
Conversation
77adac0
to
ec9b380
Compare
The sam0 rtt busy loops for 180us every time an alarm is set or the counter is read, this propagates and leads to timing errors on ztimer_msec that are higher than > +-1msec. The same goes for fe310.
ec9b380
to
c21c01b
Compare
every read of any timer in these things has to be syncronised 👀 |
Yes but its only on slow timers that it really hurts |
@fjmolinas If you're not in a hurry, I can have at SAMD21 to see if there is a way to speed up the sync process instead ? |
Not in a hurry other than wanting this one in the release, and I'm also on vacation tomorrow for the next month, I think it's ok to get this in after soft feature freeze, but you would have to push it forward for me :) |
@dylad do you mind if we get this in and you can re-add/revert if you figure out a solution? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I read: plausible ✔️
I checked the results of info-module of master and pr with without kconfig: ✔️
I trust the test results by the run by @fjmolinas ✔️
I think this is a good temporary fix (workround) for an issue due to automatic rtt use which the sam and fe310 periph implementation isn't yet good for .
Contribution description
The sam0 rtt busy loops for 180us every time an alarm is set or
the counter is read, this propagates and leads to timing errors
on ztimer_msec that are higher than > +-1msec.
The same foes for fe310.
Testing procedure
ztimer_periph_rtt
is not selected for those boardsThe lacking performance can be seen with #17391:
Realted Issues
Found while teseting #17357