Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drivers/sdcard_spi: convert to ztimer_usec #17361

Merged
merged 4 commits into from
Dec 9, 2021

Conversation

fjmolinas
Copy link
Contributor

Contribution description

Offline @bergzand asked if I could split the different changes in #17233, so here goes only migrating to ztimer.

There is an uncristify commit so commits are better reviewed one by one.

Testing procedure

  • sdcard tests still work, tested on samr21-xpro + io1-xplained shield. Using fatfs.
mount
2021-12-09 08:16:34,342 # mount
2021-12-09 08:16:34,381 # /sda successfully mounted
> ls /sda
2021-12-09 08:16:36,281 # ls /sda
2021-12-09 08:16:36,286 # SDA
2021-12-09 08:16:36,286 # TEST.TXT
2021-12-09 08:16:36,288 # total 2 files
> cat /sda/SDA/
2021-12-09 08:16:43,609 # cat /sda/SDA/
2021-12-09 08:16:43,612 # file /sda/SDA/ does not exist
> cat /sda/TEST.TXT
2021-12-09 08:16:49,606 # cat /sda/TEST.TXT
2021-12-09 08:16:51,503 # hello> cat /sda/TEST.TXT
tee /sda/test2.txt "hello hello\n"
2021-12-09 08:17:03,619 # hello> tee /sda/test2.txt "hello hello\n"
> cat /sda/test2.txt
2021-12-09 08:17:11,010 # cat /sda/test2.txt
2021-12-09 08:17:12,290 # hello hellon> cat /sda/test2.txt

Issues/PRs references

Split from #17233

@github-actions github-actions bot added Area: drivers Area: Device drivers Area: Kconfig Area: Kconfig integration labels Dec 9, 2021
@fjmolinas fjmolinas added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Dec 9, 2021
@github-actions github-actions bot added the Area: tests Area: tests and testing framework label Dec 9, 2021
@bergzand
Copy link
Member

bergzand commented Dec 9, 2021

In general I'm okay with the changes in this PR. I've spotted a few sleeps that could be converted to use the millisecond timer, but I'm fine with putting that in a follow up.

@bergzand
Copy link
Member

bergzand commented Dec 9, 2021

Please squash!

Copy link
Member

@bergzand bergzand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack, changes look good and the test output is provided.

@fjmolinas fjmolinas removed the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Dec 9, 2021
@fjmolinas
Copy link
Contributor Author

I casted at the wrong place, squashed right away

@bergzand
Copy link
Member

bergzand commented Dec 9, 2021

My ack holds

@fjmolinas fjmolinas added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Dec 9, 2021
@bergzand bergzand merged commit d0eb8e2 into RIOT-OS:master Dec 9, 2021
@fjmolinas fjmolinas added this to the Release 2022.01 milestone Jan 21, 2022
@fjmolinas fjmolinas deleted the pr_sdcard_ztimer branch January 31, 2022 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: drivers Area: Device drivers Area: Kconfig Area: Kconfig integration Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants