-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
drivers/sdcard_spi: convert to ztimer_usec #17361
Conversation
In general I'm okay with the changes in this PR. I've spotted a few sleeps that could be converted to use the millisecond timer, but I'm fine with putting that in a follow up. |
Please squash! |
e96bbaa
to
cfe9d82
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ack, changes look good and the test output is provided.
cfe9d82
to
9747204
Compare
I casted at the wrong place, squashed right away |
My ack holds |
Contribution description
Offline @bergzand asked if I could split the different changes in #17233, so here goes only migrating to ztimer.
There is an uncristify commit so commits are better reviewed one by one.
Testing procedure
samr21-xpro
+io1-xplained
shield. Using fatfs.Issues/PRs references
Split from #17233