cpu/esp: compile optional modules in CI #17314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gschorcht
added
the
CI: ready for build
github-actions
bot
added
Area: boards
gschorcht
added
CI: ready for build
To test compilation of optional ESP32 modules, these modules are enabled for the `esp32-wrover-kit` borad when compiled in CI. The use of some of these optional modules depend on the use of other modules.
To test compilation of optional ESP8266 modules, these modules are enabled for the `esp8266-olimex-mod` board when compiled in CI. The use of some of these optional modules depend on the use of other modules.
gschorcht
force-pushed
the
boards/esp/compile_optional_modules
branch
from
9f03517 to
891a0aa
Compare
|
@benpicco @kaspar030 This approach seems to work without the need to create copies of existing test applications for optional ESP modules as in PR #12971 or to define a new virtual board that uses them. The compilation of these optional modules does not depend on additional defines, i.e. it is sufficient to compile them for one board. |
benpicco
approved these changes
Dec 9, 2021
|
@benpicco Can we merge? |
|
Sure! |
|
Thanks for reviewing and merging. |
This was referenced Jan 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
A number of optional ESP modules (#12960) can be used by an application to select additional features of the ESP implementation. Since these optional ESP modules are not enabled by default, they are not covered by the compilation test in CI. This led to compilation issues in the past from time to time, for example #17305.
This PR adds some dependencies for two boards (an ESP8266 and an ESP32 board) that enable all these optional ESP modules when compiled in the CI. Some of these optional ESP models are used by these boards by default, others are only used in certain test applications depending on the use of other modules.
This PR is a try to solve the problem without the necessity to create copies of existing test applications for these optional modules like in PR #12971 or to define a new virtual board that uses them.
Testing procedure
Compilation should succeed in CI.
Issues/PRs references