drivers/mhz19: migrate to ztimer #17308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aabadie
requested review from
cgundogan,
fjmolinas,
jia200x,
leandrolanzieri,
MichelRottleuthner and
smlng
as code owners
github-actions
bot
added
Area: drivers
aabadie
added
the
CI: ready for build
|
@basilfx you provided the initial PR any chance you could test? I'm incline to ACK this otherwise since the changes seem straightforward enough, |
fjmolinas
approved these changes
Dec 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
Changes should be straight forward but care should be taken with the ppm computation which depends on ztimer_now results (expressed in ticks).
Testing procedure
tests/driver_mhz19is still working (but I don't have the hardware to test)Issues/PRs references